* [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10
@ 2021-03-04 6:40 Athira Rajeev
2021-03-09 11:28 ` Madhavan Srinivasan
2021-04-29 14:01 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Athira Rajeev @ 2021-03-04 6:40 UTC (permalink / raw)
To: mpe; +Cc: maddy, linuxppc-dev
Memory events (mem-loads and mem-stores) currently use the threshold
event selection as issue to finish. Power10 supports issue to complete
as part of thresholding which is more appropriate for mem-loads and
mem-stores. Hence fix the event code for memory events to use issue
to complete.
Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support")
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
---
arch/powerpc/perf/power10-events-list.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h
index e45dafe818ed..93be7197d250 100644
--- a/arch/powerpc/perf/power10-events-list.h
+++ b/arch/powerpc/perf/power10-events-list.h
@@ -75,5 +75,5 @@
* thresh end (TE)
*/
-EVENT(MEM_LOADS, 0x34340401e0);
-EVENT(MEM_STORES, 0x343c0401e0);
+EVENT(MEM_LOADS, 0x35340401e0);
+EVENT(MEM_STORES, 0x353c0401e0);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10
2021-03-04 6:40 [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10 Athira Rajeev
@ 2021-03-09 11:28 ` Madhavan Srinivasan
2021-04-29 14:01 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2021-03-09 11:28 UTC (permalink / raw)
To: Athira Rajeev, mpe; +Cc: linuxppc-dev
On 3/4/21 12:10 PM, Athira Rajeev wrote:
> Memory events (mem-loads and mem-stores) currently use the threshold
> event selection as issue to finish. Power10 supports issue to complete
> as part of thresholding which is more appropriate for mem-loads and
> mem-stores. Hence fix the event code for memory events to use issue
> to complete.
Changes looks fine to me.
Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>
We should also CC stable to include this fix?
> Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support")
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> ---
> arch/powerpc/perf/power10-events-list.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h
> index e45dafe818ed..93be7197d250 100644
> --- a/arch/powerpc/perf/power10-events-list.h
> +++ b/arch/powerpc/perf/power10-events-list.h
> @@ -75,5 +75,5 @@
> * thresh end (TE)
> */
>
> -EVENT(MEM_LOADS, 0x34340401e0);
> -EVENT(MEM_STORES, 0x343c0401e0);
> +EVENT(MEM_LOADS, 0x35340401e0);
> +EVENT(MEM_STORES, 0x353c0401e0);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10
2021-03-04 6:40 [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10 Athira Rajeev
2021-03-09 11:28 ` Madhavan Srinivasan
@ 2021-04-29 14:01 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-29 14:01 UTC (permalink / raw)
To: mpe, Athira Rajeev; +Cc: maddy, linuxppc-dev
On Thu, 4 Mar 2021 01:40:15 -0500, Athira Rajeev wrote:
> Memory events (mem-loads and mem-stores) currently use the threshold
> event selection as issue to finish. Power10 supports issue to complete
> as part of thresholding which is more appropriate for mem-loads and
> mem-stores. Hence fix the event code for memory events to use issue
> to complete.
Applied to powerpc/next.
[1/1] powerpc/perf: Fix the threshold event selection for memory events in power10
https://git.kernel.org/powerpc/c/66d9b7492887d34c711bc05b36c22438acba51b4
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-29 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-04 6:40 [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10 Athira Rajeev
2021-03-09 11:28 ` Madhavan Srinivasan
2021-04-29 14:01 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).