From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE5A8C433E0 for ; Wed, 10 Mar 2021 01:34:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26311650F2 for ; Wed, 10 Mar 2021 01:34:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26311650F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4DwF3w3P92z3cPp for ; Wed, 10 Mar 2021 12:34:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ZK7yoTO7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1033; helo=mail-pj1-x1033.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ZK7yoTO7; dkim-atps=neutral Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DwF3S5pGrz30RR for ; Wed, 10 Mar 2021 12:33:56 +1100 (AEDT) Received: by mail-pj1-x1033.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so6306758pjh.1 for ; Tue, 09 Mar 2021 17:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=bk2gbXj7lVPQspVhwjnWs8ssO+83Zc6YrCjiO0hiGow=; b=ZK7yoTO7YgUN2ikGdYvBBxnFHZlkxpq4eADMqVD4AZknTxG4DhR/6WXNzfVDudcqwZ F8jjnKdMoVDM7Neo/fOY5tGOXHRVMkaFlh5nZI91TiTJgkRZ8PJEj+AwXJFnEAsHA0P8 SmT2+cJ9jGCj4Zl96a4JnxB8HHdFLK1H1x5ylKrfN19rVvHyCKYv+XGLo6PYHCFAo1Zy 3PW9xT3GWIHFiaU0DLWA8AO43RPQ96ZRjnYb6I8clypkojZfem69/CNOmOI/GuaQ5oJN sT+0cQcPfPvfw0kSWgNa8W2KpTDw1XkyfuAiIHcrMKfh/m2xxUg+1DjQtds9BBlSBUEU FNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=bk2gbXj7lVPQspVhwjnWs8ssO+83Zc6YrCjiO0hiGow=; b=Lp4r/Cc3Fdd8RQCYoZaWaCLJJ0m6jH+Z2OLssJ4GXCcUG9ExhvgQG6xf/flSvIh9S5 NfGXPQtyDCplLB4bR7sTBDnBv1Rf+AwGuoGzNsgxtHT8UWgiel/y8xVlQLV57Py6mBQV l5xraXeXUb0XPdiBfhZxk9sTJrY36bq17ZxXyZf0xJLA5gjp1GH6IXWdc5gX8os7bpww UP5t8hQsZ2clJ4MAkwNk8pYh+8+4lS7SauxoyUhWsdn+Ozqz/aA/NrbugQcPeDNGaPNM mHk8jixvt7EjRtBT4fBBDo2PyrIUuaaD394pHnra2EgOthTeiA1wsQEbrSQkhWmha2Xs aZaA== X-Gm-Message-State: AOAM532C2QwkDJHo38dMjpqOYS+rgvHpPNiUXZ1ehaYd0PSkCYnD7Lqo cIkurlk7oZXgmf59l7V9h1Y= X-Google-Smtp-Source: ABdhPJy2HN27jz4a5QTummRE+dZi2bKOXRGhtGb8kVTmwRdp+g5WgQtHEmb6K/7hPGkiu4ADl8Zt9w== X-Received: by 2002:a17:90b:3550:: with SMTP id lt16mr802543pjb.47.1615340033713; Tue, 09 Mar 2021 17:33:53 -0800 (PST) Received: from localhost (58-6-239-121.tpgi.com.au. [58.6.239.121]) by smtp.gmail.com with ESMTPSA id s10sm14061433pgl.90.2021.03.09.17.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 17:33:53 -0800 (PST) Date: Wed, 10 Mar 2021 11:33:47 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 36/43] powerpc/32: Set current->thread.regs in C interrupt entry To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras References: <8d523f9ecee1de0515cc31d43030c12ab171a670.1615291474.git.christophe.leroy@csgroup.eu> In-Reply-To: <8d523f9ecee1de0515cc31d43030c12ab171a670.1615291474.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1615339900.vmbtzuirqw.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Christophe Leroy's message of March 9, 2021 10:10 pm: > No need to do that is assembly, do it in C. Hmm. No issues with the patch as such, but why does ppc32 need this but=20 not 64? AFAIKS 64 sets this when a thread is created. Thanks, Nick >=20 > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/interrupt.h | 4 +++- > arch/powerpc/kernel/entry_32.S | 3 +-- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/= asm/interrupt.h > index 861e6eadc98c..e6d71c2e3aa2 100644 > --- a/arch/powerpc/include/asm/interrupt.h > +++ b/arch/powerpc/include/asm/interrupt.h > @@ -33,8 +33,10 @@ static inline void interrupt_enter_prepare(struct pt_r= egs *regs, struct interrup > if (!arch_irq_disabled_regs(regs)) > trace_hardirqs_off(); > =20 > - if (user_mode(regs)) > + if (user_mode(regs)) { > + current->thread.regs =3D regs; > account_cpu_user_entry(); > + } > #endif > /* > * Book3E reconciles irq soft mask in asm > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_3= 2.S > index 8fe1c3fdfa6e..815a4ff1ba76 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -52,8 +52,7 @@ > prepare_transfer_to_handler: > andi. r0,r9,MSR_PR > addi r12, r2, THREAD > - beq 2f /* if from user, fix up THREAD.regs */ > - stw r3,PT_REGS(r12) > + beq 2f > #ifdef CONFIG_PPC_BOOK3S_32 > kuep_lock r11, r12 > #endif > --=20 > 2.25.0 >=20 >=20