From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 2/4] powerpc/pseries: Don't trace hcall tracing wrapper
Date: Tue, 27 Apr 2021 19:22:24 +0530 [thread overview]
Message-ID: <1619531352.qz8apiknnh.naveen@linux.ibm.com> (raw)
In-Reply-To: <20210423031108.1046067-3-npiggin@gmail.com>
Nicholas Piggin wrote:
> This doesn't seem very useful to trace before the recursion check, even
> if the ftrace code has any recursion checks of its own. Be on the safe
> side and don't trace the hcall trace wrappers.
These functions exist precisely to allow hcalls to be traced, so it
doesn't make sense to "trace the tracer". Users wanting to know about
hcalls are better off enabling the tracepoint here instead.
>
> Reported-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> arch/powerpc/platforms/pseries/lpar.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
- Naveen
next prev parent reply other threads:[~2021-04-27 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 3:11 [PATCH 0/4] Fix queued spinlocks and a bit more Nicholas Piggin
2021-04-23 3:11 ` [PATCH 1/4] powerpc/pseries: Fix hcall tracing recursion in pv queued spinlocks Nicholas Piggin
2021-04-27 13:43 ` Naveen N. Rao
2021-05-01 1:22 ` Nicholas Piggin
2021-05-02 13:48 ` Michael Ellerman
2021-04-23 3:11 ` [PATCH 2/4] powerpc/pseries: Don't trace hcall tracing wrapper Nicholas Piggin
2021-04-27 13:52 ` Naveen N. Rao [this message]
2021-04-23 3:11 ` [PATCH 3/4] powerpc/pseries: use notrace hcall variant for H_CEDE idle Nicholas Piggin
2021-04-27 13:53 ` Naveen N. Rao
2021-04-23 3:11 ` [PATCH 4/4] powerpc/pseries: warn if recursing into the hcall tracing code Nicholas Piggin
2021-04-27 13:59 ` Naveen N. Rao
2021-05-01 1:24 ` Nicholas Piggin
2021-05-04 10:25 ` Naveen N. Rao
2021-05-04 10:45 ` Nicholas Piggin
2021-05-04 16:18 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619531352.qz8apiknnh.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).