From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99ADEC433B4 for ; Tue, 27 Apr 2021 13:53:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB67A613C0 for ; Tue, 27 Apr 2021 13:53:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB67A613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FV3B61Xz2z301D for ; Tue, 27 Apr 2021 23:53:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cYwbXIUS; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=naveen.n.rao@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=cYwbXIUS; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FV39c12BSz2xgJ for ; Tue, 27 Apr 2021 23:52:35 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13RDXE2U003668 for ; Tue, 27 Apr 2021 09:52:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : subject : to : references : in-reply-to : mime-version : message-id : content-type : content-transfer-encoding; s=pp1; bh=6O7LjSJLgh/EOY2KZ0p0x4O1uRXP6xpE8JNLJfMm00E=; b=cYwbXIUS/GIJNA5sbDivTHpcmj6aEnWM5TX3q556SnZD7zQR44aK5JAIbxMsFPEHD7iG e1vKqmUBgXvHxDT2Mw1FLbyPpQfW05K+g6NL6rtm/Swd3N9MkWFlZ7avhMeIcZa9oW8K PSkrdZyOMrLpPfSR/J/uu1/H837RgjAaJpjI7MkbcshU32xZktaBtL7MP4gTA4fkzaC2 2y0hY+vnb1qaHPAKXWkig71ngUgVD3WTj7VRj8B7mAZGmYgTKKtcLzd6uI0r8q2xP9zc Vq/AXNKM2RD8MCGlH++ZBZTyWNpLeACdMJtncSHDc7iP/0Xx5r/2W9ZP2Qiw1Qyo9DzP NQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 386gvx6dpp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Apr 2021 09:52:32 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13RDYgti010439 for ; Tue, 27 Apr 2021 09:52:31 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0b-001b2d01.pphosted.com with ESMTP id 386gvx6dn9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 09:52:31 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13RDmNAS008716; Tue, 27 Apr 2021 13:52:30 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06fra.de.ibm.com with ESMTP id 384akh8s4w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 13:52:29 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13RDqQ1j32178486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Apr 2021 13:52:26 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B7D4BA4057; Tue, 27 Apr 2021 13:52:26 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB55BA4053; Tue, 27 Apr 2021 13:52:25 +0000 (GMT) Received: from localhost (unknown [9.85.74.4]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 27 Apr 2021 13:52:25 +0000 (GMT) Date: Tue, 27 Apr 2021 19:22:24 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH 2/4] powerpc/pseries: Don't trace hcall tracing wrapper To: linuxppc-dev@lists.ozlabs.org, Nicholas Piggin References: <20210423031108.1046067-1-npiggin@gmail.com> <20210423031108.1046067-3-npiggin@gmail.com> In-Reply-To: <20210423031108.1046067-3-npiggin@gmail.com> MIME-Version: 1.0 User-Agent: astroid/v0.15-23-gcdc62b30 (https://github.com/astroidmail/astroid) Message-Id: <1619531352.qz8apiknnh.naveen@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: O278wTIU23letv2DGs1EDjd0WpYsA1l3 X-Proofpoint-GUID: YH90RHnFpHq22Z-wYxVV0ZWKR1EGCaWU X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-27_08:2021-04-27, 2021-04-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 mlxscore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=692 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104270098 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Nicholas Piggin wrote: > This doesn't seem very useful to trace before the recursion check, even > if the ftrace code has any recursion checks of its own. Be on the safe > side and don't trace the hcall trace wrappers. These functions exist precisely to allow hcalls to be traced, so it=20 doesn't make sense to "trace the tracer". Users wanting to know about=20 hcalls are better off enabling the tracepoint here instead. >=20 > Reported-by: Naveen N. Rao > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/platforms/pseries/lpar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Naveen N. Rao - Naveen