From: Paul Mackerras <paulus@samba.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: sound on dual G4 powermac
Date: Tue, 26 Aug 2003 14:38:08 +1000 [thread overview]
Message-ID: <16202.58416.134657.827441@cargo.ozlabs.ibm.com> (raw)
I have been using this patch in 2.5/2.6 kernels on my dual G4 powermac
for some time. Without it, I get no sound at all, even after
unmuting. I don't know exactly why this fixes it, but this is what I
came up with in the process of doing a binary search between a kernel
that worked and one that didn't.
Paul.
diff -urN linux-2.5/sound/ppc/tumbler.c pmac-2.5/sound/ppc/tumbler.c
--- linux-2.5/sound/ppc/tumbler.c 2003-08-02 09:37:36.000000000 +1000
+++ pmac-2.5/sound/ppc/tumbler.c 2003-08-09 09:53:12.000000000 +1000
@@ -976,6 +976,9 @@
chip->mixer_data = mix;
chip->mixer_free = tumbler_cleanup;
+ if ((err = tumbler_init(chip)) < 0)
+ return err;
+
/* set up TAS */
tas_node = find_devices("deq");
if (tas_node == NULL)
@@ -1022,9 +1025,6 @@
if ((err = snd_ctl_add(chip->card, chip->speaker_sw_ctl)) < 0)
return err;
- if ((err = tumbler_init(chip)) < 0)
- return err;
-
#ifdef CONFIG_PMAC_PBOOK
chip->resume = tumbler_resume;
#endif
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next reply other threads:[~2003-08-26 4:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 4:38 Paul Mackerras [this message]
2003-08-27 16:46 ` sound on dual G4 powermac Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16202.58416.134657.827441@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).