From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linuxarm@openeuler.org
Subject: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments
Date: Mon, 17 May 2021 14:37:10 +0800 [thread overview]
Message-ID: <1621233433-27094-7-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com>
Fix coding style issues of block comments, reported by checkpatch.pl.
Besides, add a period at the end of the sentenses.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/tty/hvc/hvc_console.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 39018e5..a61cdf0 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b,
r = cons_ops[index]->put_chars(vtermnos[index], c, i);
if (r <= 0) {
/* throw away characters on error
- * but spin in case of -EAGAIN */
+ * but spin in case of -EAGAIN.
+ */
if (r != -EAGAIN) {
i = 0;
} else {
@@ -484,7 +485,8 @@ static int hvc_push(struct hvc_struct *hp)
return 0;
}
/* throw away output on error; this happens when
- there is no session connected to the vterm. */
+ * there is no session connected to the vterm.
+ */
hp->n_outbuf = 0;
} else
hp->n_outbuf -= n;
@@ -707,7 +709,8 @@ static int __hvc_poll(struct hvc_struct *hp, bool may_sleep)
/* XXX should support a sequence */
if (buf[i] == '\x0f') { /* ^O */
/* if ^O is pressed again, reset
- * sysrq_pressed and flip ^O char */
+ * sysrq_pressed and flip ^O char.
+ */
sysrq_pressed = !sysrq_pressed;
if (sysrq_pressed)
continue;
@@ -749,7 +752,8 @@ static int __hvc_poll(struct hvc_struct *hp, bool may_sleep)
if (read_total) {
/* Activity is occurring, so reset the polling backoff value to
- a minimum for performance. */
+ * a minimum for performance.
+ */
timeout = MIN_TIMEOUT;
tty_flip_buffer_push(&hp->port);
@@ -1037,7 +1041,8 @@ static int hvc_init(void)
tty_set_operations(drv, &hvc_ops);
/* Always start the kthread because there can be hotplug vty adapters
- * added later. */
+ * added later.
+ */
hvc_task = kthread_run(khvcd, NULL, "khvcd");
if (IS_ERR(hvc_task)) {
printk(KERN_ERR "Couldn't create kthread for console.\n");
--
2.8.1
next prev parent reply other threads:[~2021-05-17 8:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 6:37 [PATCH 0/9] tty: hvc_console: Fix some coding style issues Xiaofei Tan
2021-05-17 6:37 ` [PATCH 1/9] tty: hvc_console: Fix spaces required around that '=' Xiaofei Tan
2021-05-17 6:37 ` [PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar" Xiaofei Tan
2021-05-17 6:37 ` [PATCH 3/9] tty: hvc_console: Remove trailing whitespace Xiaofei Tan
2021-05-17 6:37 ` [PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs Xiaofei Tan
2021-05-17 6:37 ` [PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')' Xiaofei Tan
2021-05-17 6:37 ` Xiaofei Tan [this message]
2021-05-17 14:15 ` [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Johan Hovold
2021-05-18 4:01 ` Xiaofei Tan
2021-05-20 8:21 ` Johan Hovold
2021-05-20 13:21 ` Xiaofei Tan
2021-05-20 13:52 ` Johan Hovold
2021-05-21 2:23 ` Xiaofei Tan
2021-05-20 15:21 ` Joe Perches
2021-05-21 8:44 ` Johan Hovold
2021-05-17 6:37 ` [PATCH 7/9] tty: hvc_console: Add a blank line after declarations Xiaofei Tan
2021-05-17 6:37 ` [PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from' Xiaofei Tan
2021-05-17 6:37 ` [PATCH 9/9] tty: hvc_console: Move open brace { on the previous line Xiaofei Tan
2021-05-20 15:11 ` [PATCH 0/9] tty: hvc_console: Fix some coding style issues Greg KH
2021-05-21 2:18 ` Xiaofei Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621233433-27094-7-git-send-email-tanxiaofei@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).