From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in-14.arcor-online.net (mail-in-14.arcor-online.net [151.189.21.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.arcor.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 733A5B6F2B for ; Wed, 11 Nov 2009 19:32:27 +1100 (EST) Message-ID: <16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local> Date: Wed, 11 Nov 2009 09:32:22 +0100 (CET) From: "Albrecht Dreß" To: grant.likely@secretlab.ca Subject: Aw: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1257884778.14374.5@antares> Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org, wim@iguana.be List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Grant: O.k., thanks for your comments. If Wim doesn't have any objections to it, = I will provide a merged patch. One consequence I forgot to mention is that= we loose the ability to build the wdt support as module, but I don't think= it's a real problem. I think we still should keep the kernel config option enable/disable the wd= t support, which would mask out the wdt code if disabled. Is that ok for y= ou? Thanks, Albrecht. ----- Original Nachricht ---- Von: Grant Likely An: Albrecht Dre=DF Datum: 10.11.2009 22:07 Betreff: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api > On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dre=DF > wrote: > > Hi Grant: > > > > Am 10.11.09 20:59 schrieb(en) Grant Likely: > >> > >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dre=DF > > >> wrote: > >> > Use the MPC5200 GPT api for the WDT which drastically simplifies thi= s > >> > file. > >> > > >> > Signed-off-by: Albrecht Dre=DF > >> > --- > >> > > >> > =A0drivers/watchdog/mpc5200_wdt.c | =A0246 > >> > +++++++++++----------------------------- > >> > =A01 files changed, 65 insertions(+), 181 deletions(-) > >> > >> > >> Can the WDT functionality just be merged entirely into > >> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for > >> this file entirely? =A0I think I'd rather have all the GPT "built in" > >> behaviour handled by a single driver. > > > > I also thought about it, as it has IMHO the cleaner code, and it would > have > > the extra benefit that the gpt-wdt api doesn't need to be public. > > > > However, the reasons I hesitated to do so are: > > - I don't want to remove a file someone else wrote (even it doesn't > work); >=20 > Shouldn't be a problem, and I'll handle the fallout if it is. >=20 > > - WDT code is shifted from drivers/watchdog to > arch/powerpc/platforms/52xx > > which might not be the "logical" place from the directory layout's pov; >=20 > There is precedence of this in the past, particularly on arch or > platform specific hardware drivers and multifunction devices. (Heck, > that's almost entirely what arch/powerpc/sysdev is). I'm not > concerned. >=20 > > - a file living in arch/powerpc/platforms/52xx depends upon config > options > > set from drivers/watchdog/Kconfig which may be confusing. >=20 > I'm not concerned about this either. >=20 > > You see these are more political/cosmetical questions, so I would prefe= r > to > > leave the decision to the maintainers (i.e. you and Wim). =A0Preparing = a > fully > > merged driver is actually a matter of minutes! >=20 > Do it. I'll champion getting it in. Wim, do you have any issues with > this? >=20 > g. >=20 > --=20 > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >=20 Jetzt NEU: Do it youself E-Cards bei Arcor.de! Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empf=E4nger eine= ganz pers=F6nliche Freude! E-Card Marke Eigenbau: HIER KLICKEN: http://www.arcor.de/rd/footer.ecard