From: Nicholas Piggin <npiggin@gmail.com>
To: Christian Zigotzky <chzigotzky@xenosoft.de>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
mad skateman <madskateman@gmail.com>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: [FSL P50xx] IRQ issues
Date: Tue, 06 Jul 2021 09:36:11 +1000 [thread overview]
Message-ID: <1625527692.m58rsysc62.astroid@bobo.none> (raw)
In-Reply-To: <cc1b16c0-47d5-2c50-fba0-9e1aa014ee8a@xenosoft.de>
Excerpts from Christian Zigotzky's message of July 6, 2021 4:49 am:
> Hi All,
>
> Our FSL P50xx machines don't boot anymore because of IRQ issues. [1]
>
> Please check the IRQ changes in the latest PowerPC updates 5.14-1. [2]
>
> Thanks,
> Christian
>
> [1]
> https://forum.hyperion-entertainment.com/download/file.php?id=2592&mode=view
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=019b3fd94ba73d3ac615f0537440b81f129821f6
This looks like mtmsrd in the 64e code. I think this should fix it.
QEMU does not seem to trap on this, maybe something to improve.
Thanks,
Nick
--
diff --git a/arch/powerpc/kernel/interrupt_64.S b/arch/powerpc/kernel/interrupt_64.S
index 4063e8a3f704..d4212d2ff0b5 100644
--- a/arch/powerpc/kernel/interrupt_64.S
+++ b/arch/powerpc/kernel/interrupt_64.S
@@ -311,9 +311,13 @@ END_BTB_FLUSH_SECTION
* trace_hardirqs_off().
*/
li r11,IRQS_ALL_DISABLED
- li r12,-1 /* Set MSR_EE and MSR_RI */
stb r11,PACAIRQSOFTMASK(r13)
+#ifdef CONFIG_PPC_BOOK3S
+ li r12,-1 /* Set MSR_EE and MSR_RI */
mtmsrd r12,1
+#else
+ wrteei 1
+#endif
/* Calling convention has r9 = orig r0, r10 = regs */
mr r9,r0
next prev parent reply other threads:[~2021-07-05 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210509224926.GA31035@embeddedor>
[not found] ` <CADnq5_OWk+rXK5xrwu0YOMVC45WyQgFQBTUNkcF8oO3ucp+=XQ@mail.gmail.com>
[not found] ` <ba5f2a73-58e8-6b3e-4048-bb19f238be51@embeddedor.com>
2021-07-03 7:30 ` Xorg doesn't work anymore after the latest DRM updates Christian Zigotzky
2021-07-03 7:57 ` Christian Zigotzky
2021-07-05 18:49 ` [FSL P50xx] IRQ issues Christian Zigotzky
2021-07-05 23:36 ` Nicholas Piggin [this message]
2021-07-06 4:07 ` Christian Zigotzky
2021-07-06 15:22 ` Christian Zigotzky
2021-07-07 9:29 ` Nicholas Piggin
2021-07-06 4:26 ` Nicholas Piggin
2021-07-05 8:26 ` Xorg doesn't work anymore after the latest DRM updates Das, Nirmoy
2021-07-05 16:48 ` Christian Zigotzky
2021-07-06 15:33 ` Christian Zigotzky
2021-07-06 16:58 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625527692.m58rsysc62.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=info@xenosoft.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madskateman@gmail.com \
--cc=rtd2@xtra.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).