From: Segher Boessenkool <segher@kernel.crashing.org>
To: Akinobu Mita <mita@fixstars.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
cbe-oss-dev@ozlabs.org
Subject: Re: [patch 1/3] powerpc: delete -mstring option
Date: Tue, 10 Apr 2007 14:47:38 +0200 [thread overview]
Message-ID: <16327e0d9602022d7ee57670ac23c383@kernel.crashing.org> (raw)
In-Reply-To: <20070410111324.GA2957@localhost.localdomain>
> There is no reason to force -mstring option.
> (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)
> -ifndef CONFIG_FSL_BOOKE
> -CFLAGS += -mstring
> -endif
[and from 2/3]
> +ifeq ($(CONFIG_FSL_BOOKE),y)
> +CFLAGS += -mno-string
> +endif
This is the right solution, thank you for the patch.
But please fold these two together so that you're not
introducing a regression halfway the patch series.
Segher
next prev parent reply other threads:[~2007-04-10 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 11:13 [patch 1/3] powerpc: delete -mstring option Akinobu Mita
2007-04-10 12:47 ` Segher Boessenkool [this message]
2007-04-10 18:42 ` Kumar Gala
2007-04-11 2:35 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16327e0d9602022d7ee57670ac23c383@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mita@fixstars.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).