From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D3CC433EF for ; Fri, 15 Oct 2021 05:58:48 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC5606115C for ; Fri, 15 Oct 2021 05:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC5606115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HVwYx6w4mz3c8n for ; Fri, 15 Oct 2021 16:58:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=BvkezB9D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102d; helo=mail-pj1-x102d.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=BvkezB9D; dkim-atps=neutral Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HVwY80RyDz2yy3 for ; Fri, 15 Oct 2021 16:58:03 +1100 (AEDT) Received: by mail-pj1-x102d.google.com with SMTP id ls18so6491197pjb.3 for ; Thu, 14 Oct 2021 22:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=S0rBIBfnndl4sO0SZD30iqTuRSBoy5r+zNmXEO729ec=; b=BvkezB9DzKzErquz1XZOTKqoL0XOL3U6Eb5odSJ6flnnPgmmGEa3vMoyopsdwVJpIo +kJ9msCSx7YGPh77U30LXnNLubl1IugeDdeSuYmeI37nvbmhSm5CsYs8iAoSKXMNhzxO 6i912LlK4afHQGJIc4S85mDVOKR5UpDhCrBkxj6ietrjMxi2fywEBEuiLIZgu19q/I1g +8t1vHWN0EHqjETvz4uZZN6EvLLpsZtZkFFYte3N8uN6vsiAuv/ZnqxmivZw24+wB8Ud WkPTCZYNe4CFVIiv/WGJwu9SWhmgRP+wcQq7L1rL9ZDmaijfZRGwseytUWA+JVHD4hhp bQ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=S0rBIBfnndl4sO0SZD30iqTuRSBoy5r+zNmXEO729ec=; b=7wcMKg2O34hgzWbQo65ATBolK7Uv9GYdemK5LvSwtbyuXdTA9GZRllJUcuvFt/8DWk CBlBZ97eOr3gs7dcrBTdk4EJstxy/He8PRDm70/UZPYjICnmEDEoN2yWjuuRR0HNfmTj kMyUwK7k92GyzUbypX0LdEaJpL5PbFZAK+z3hOjLSXZX1UdEAmBQG242XxVc7wECFHPG Z882Da4RbuNLoIwniNkcc42mbgorE7+l0JoafrOIBLioM3VWirErVueNDnroVigavAAT eOq9bzlQVpaAoRh/SI7KlEoCVwouOyC+2b+kVZDfBK5HA6WTJJNAqWwuYWB7Q2y3CVbp YJKA== X-Gm-Message-State: AOAM533icOmQhwdYa61FhHRS11J425fbRwA3UF0tHyMXKFIvGxxR66M5 UwFatIoNhGBzaZpanph5Eip2kpgsVgc= X-Google-Smtp-Source: ABdhPJyXz4rN56bUpmFK5R707chQeiJbYyyVjPcMsN6ywtX2cPlh5ALJb3tBLebih8BJB0NaHGRlvg== X-Received: by 2002:a17:902:d488:b0:13f:165e:f491 with SMTP id c8-20020a170902d48800b0013f165ef491mr9412847plg.12.1634277481786; Thu, 14 Oct 2021 22:58:01 -0700 (PDT) Received: from localhost (14-203-144-177.static.tpgi.com.au. [14.203.144.177]) by smtp.gmail.com with ESMTPSA id t126sm4092988pfc.80.2021.10.14.22.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 22:58:01 -0700 (PDT) Date: Fri, 15 Oct 2021 15:57:56 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 01/13] powerpc: Move 'struct ppc64_opd_entry' back into asm/elf.h To: Andrew Morton , Arnd Bergmann , Benjamin Herrenschmidt , Christophe Leroy , Helge Deller , Greg Kroah-Hartman , "James E.J. Bottomley" , Kees Cook , Michael Ellerman , Paul Mackerras References: <42d2a571677e60082c0a5b3e52e855aa58c0b1fc.1634190022.git.christophe.leroy@csgroup.eu> In-Reply-To: <42d2a571677e60082c0a5b3e52e855aa58c0b1fc.1634190022.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1634277306.r82aohhn4e.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Christophe Leroy's message of October 14, 2021 3:49 pm: > 'struct ppc64_opd_entry' doesn't belong to uapi/asm/elf.h >=20 > It was initially in module_64.c and commit 2d291e902791 ("Fix compile > failure with non modular builds") moved it into asm/elf.h >=20 > But it was by mistake added outside of __KERNEL__ section, > therefore commit c3617f72036c ("UAPI: (Scripted) Disintegrate > arch/powerpc/include/asm") moved it to uapi/asm/elf.h >=20 > Move it back into asm/elf.h, this brings it back in line with > IA64 and PARISC architectures. >=20 > Fixes: 2d291e902791 ("Fix compile failure with non modular builds") > Reviewed-by: Kees Cook > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/elf.h | 6 ++++++ > arch/powerpc/include/uapi/asm/elf.h | 8 -------- > 2 files changed, 6 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/el= f.h > index b8425e3cfd81..a4406714c060 100644 > --- a/arch/powerpc/include/asm/elf.h > +++ b/arch/powerpc/include/asm/elf.h > @@ -176,4 +176,10 @@ do { \ > /* Relocate the kernel image to @final_address */ > void relocate(unsigned long final_address); > =20 > +/* There's actually a third entry here, but it's unused */ > +struct ppc64_opd_entry { > + unsigned long funcaddr; > + unsigned long r2; > +}; Reviewed-by: Nicholas Piggin I wonder if we should add that third entry, just for completeness. And=20 'r2' isn't a good name should probably be toc. And should it be packed?=20 At any rate that's not for your series, a cleanup I might think about for later. Thanks, Nick