From: Nicholas Piggin <npiggin@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 16/16] powerpc/microwatt: Don't select the hash MMU code
Date: Thu, 21 Oct 2021 17:38:51 +1000 [thread overview]
Message-ID: <1634801796.rx7phmr7bf.astroid@bobo.none> (raw)
In-Reply-To: <CACPK8XfuR6QqyP-Bj8S6APbVNugTJLZuARfNHN6Knqe+-MeKSA@mail.gmail.com>
Excerpts from Joel Stanley's message of October 21, 2021 3:19 pm:
> On Thu, 21 Oct 2021 at 04:04, Nicholas Piggin <npiggin@gmail.com> wrote:
>>
>> Microwatt is radix-only, so it does not require hash MMU support.
>>
>> This saves 20kB compressed dtbImage and 56kB vmlinux size.
>>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>> ---
>> arch/powerpc/configs/microwatt_defconfig | 1 -
>> arch/powerpc/platforms/microwatt/Kconfig | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/arch/powerpc/configs/microwatt_defconfig b/arch/powerpc/configs/microwatt_defconfig
>> index 6e62966730d3..7c8eb29d8afe 100644
>> --- a/arch/powerpc/configs/microwatt_defconfig
>> +++ b/arch/powerpc/configs/microwatt_defconfig
>> @@ -27,7 +27,6 @@ CONFIG_PPC_MICROWATT=y
>> # CONFIG_PPC_OF_BOOT_TRAMPOLINE is not set
>> CONFIG_CPU_FREQ=y
>> CONFIG_HZ_100=y
>> -# CONFIG_PPC_MEM_KEYS is not set
>> # CONFIG_SECCOMP is not set
>> # CONFIG_MQ_IOSCHED_KYBER is not set
>> # CONFIG_COREDUMP is not set
>
> We still end up with CONFIG_PPC_64S_HASH_MMU=y in the config as it
> defaults to y.
If you make microwatt_defconfig? Hm, IIRC this came from savedefconfig
after unselecting hash mmu so I'm not sure why that doesn't work.
>
> We should disable in the defconfig it so your new changes are tested
> by that defconfig:
>
> +# CONFIG_PPC_64S_HASH_MMU is not set
>
> I boot tested your series on Microwatt with microwatt_defconfig (with
> and without that option set) and ppc64le_defconfig.
Nice.
Thanks,
Nick
>
> Cheers,
>
> Joel
>
>> diff --git a/arch/powerpc/platforms/microwatt/Kconfig b/arch/powerpc/platforms/microwatt/Kconfig
>> index 823192e9d38a..5e320f49583a 100644
>> --- a/arch/powerpc/platforms/microwatt/Kconfig
>> +++ b/arch/powerpc/platforms/microwatt/Kconfig
>> @@ -5,7 +5,6 @@ config PPC_MICROWATT
>> select PPC_XICS
>> select PPC_ICS_NATIVE
>> select PPC_ICP_NATIVE
>> - select PPC_HASH_MMU_NATIVE if PPC_64S_HASH_MMU
>> select PPC_UDBG_16550
>> select ARCH_RANDOM
>> help
>> --
>> 2.23.0
>>
>
next prev parent reply other threads:[~2021-10-21 7:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 3:54 [PATCH v2 00/16] powerpc: Make hash MMU code build configurable Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 01/16] powerpc: Remove unused FW_FEATURE_NATIVE references Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 02/16] powerpc: Rename PPC_NATIVE to PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 03/16] powerpc/pseries: Stop selecting PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 04/16] powerpc/64s: Move and rename do_bad_slb_fault as it is not hash specific Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 05/16] powerpc/pseries: move pseries_lpar_register_process_table() out from hash specific code Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 06/16] powerpc/pseries: lparcfg don't include slb_size line in radix mode Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 07/16] powerpc/64s: move THP trace point creation out of hash specific file Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 08/16] powerpc/64s: Make flush_and_reload_slb a no-op when radix is enabled Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 09/16] powerpc/64s: move page size definitions from hash specific file Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 10/16] powerpc/64s: Rename hash_hugetlbpage.c to hugetlbpage.c Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 11/16] powerpc/64: pcpu setup avoid reading mmu_linear_psize on 64e or radix Nicholas Piggin
2021-10-21 4:52 ` Christophe Leroy
2021-10-21 7:13 ` Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 12/16] powerpc/64e: remove mmu_linear_psize Nicholas Piggin
2021-10-21 5:03 ` Christophe Leroy
2021-10-21 7:15 ` Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 13/16] powerpc/64s: Move hash MMU code under a new Kconfig name Nicholas Piggin
2021-10-21 5:43 ` Christophe Leroy
2021-10-21 7:33 ` Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 14/16] powerpc/64s: Make hash MMU support configurable Nicholas Piggin
2021-10-21 5:44 ` Christophe Leroy
2021-10-21 3:54 ` [PATCH v2 15/16] powerpc/configs/microwatt: add POWER9_CPU Nicholas Piggin
2021-10-21 3:54 ` [PATCH v2 16/16] powerpc/microwatt: Don't select the hash MMU code Nicholas Piggin
2021-10-21 5:19 ` Joel Stanley
2021-10-21 7:38 ` Nicholas Piggin [this message]
2021-10-21 5:47 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634801796.rx7phmr7bf.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).