From: David Howells <dhowells@redhat.com>
To: Sergey Temerkhanov <temerkhanov@yandex.ru>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Level IRQ handling on Xilinx INTC with ARCH=powerpc
Date: Tue, 29 Jul 2008 15:14:17 +0100 [thread overview]
Message-ID: <16359.1217340857@redhat.com> (raw)
In-Reply-To: <360961217332693@webmail22.yandex.ru>
Sergey Temerkhanov <temerkhanov@yandex.ru> wrote:
> And handle_level_irq() which is currently used as high-level IRQ handler for
> Xilinx INTC only tries to acknowledge IRQ before ISR call. So that the IRQ
> remains asserted in INTC and after the call to desc->chip->unmask() causes
> spurious attempt to process the same IRQ again. However, call to
> desc->chip->ack() this time finishes the required procedure of IRQ
> acknowledge.
I think I'm seeing the same on the MN10300 arch with its builtin PIC. My
soultion was to make unmask() also clear the IRQ latch in the PIC for that
channel. We perhaps want an unmask_ack() op.
David
next prev parent reply other threads:[~2008-07-29 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 11:58 Level IRQ handling on Xilinx INTC with ARCH=powerpc Sergey Temerkhanov
2008-07-29 14:14 ` David Howells [this message]
2008-07-29 21:35 ` Benjamin Herrenschmidt
2008-08-08 9:31 ` [PATCH] " Sergey Temerkhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16359.1217340857@redhat.com \
--to=dhowells@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=temerkhanov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).