From: Nicholas Piggin <npiggin@gmail.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 00/17] powerpc: Make hash MMU code build configurable
Date: Fri, 26 Nov 2021 10:55:38 +1000 [thread overview]
Message-ID: <1637887917.uatiybce4e.astroid@bobo.none> (raw)
In-Reply-To: <d792e8a6-de81-1f93-8938-d1d9d6a1e748@csgroup.eu>
Excerpts from Christophe Leroy's message of November 26, 2021 3:35 am:
>
>
> Le 25/11/2021 à 17:35, Christophe Leroy a écrit :
>>
>>
>> Le 25/11/2021 à 13:50, Nicholas Piggin a écrit :
>>> Now that there's a platform that can make good use of it, here's
>>> a series that can prevent the hash MMU code being built for 64s
>>> platforms that don't need it.
>>
>> # CONFIG_PPC_64S_HASH_MMU is not set
>>
>>
>> <stdin>:1559:2: warning: #warning syscall futex_waitv not implemented
>> [-Wcpp]
>> arch/powerpc/platforms/cell/spu_base.c: In function '__spu_kernel_slb':
>> arch/powerpc/platforms/cell/spu_base.c:215:38: error: 'mmu_linear_psize'
>> undeclared (first use in this function); did you mean 'mmu_virtual_psize'?
>> 215 | llp = mmu_psize_defs[mmu_linear_psize].sllp;
>> | ^~~~~~~~~~~~~~~~
>> | mmu_virtual_psize
>> arch/powerpc/platforms/cell/spu_base.c:215:38: note: each undeclared
>> identifier is reported only once for each function it appears in
>> make[3]: *** [scripts/Makefile.build:287:
>> arch/powerpc/platforms/cell/spu_base.o] Error 1
>> make[2]: *** [scripts/Makefile.build:549: arch/powerpc/platforms/cell]
>> Error 2
>> make[1]: *** [scripts/Makefile.build:549: arch/powerpc/platforms] Error 2
>> make: *** [Makefile:1846: arch/powerpc] Error 2
>>
>>
>
>
> With CONFIG_SPU_BASE removed, the above voids and I get to the final
> link with the following errors:
This is building cell platform with POWER9 CPU and !HASH?
We don't have to make that build, just prevent the config. I had that in
a previous version which also had platforms select hash, but we went to
just CPU. But now there's no constraint that prevents cell+POWER9 even
though it doesn't make sense.
Not sure the best way to fix it. I'll think about it.
Thanks,
Nick
next prev parent reply other threads:[~2021-11-26 0:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 12:50 [PATCH v4 00/17] powerpc: Make hash MMU code build configurable Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 01/17] powerpc: Remove unused FW_FEATURE_NATIVE references Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 02/17] powerpc: Rename PPC_NATIVE to PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 03/17] powerpc/pseries: Stop selecting PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 04/17] powerpc/64s: Move and rename do_bad_slb_fault as it is not hash specific Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 05/17] powerpc/pseries: move process table registration away from hash-specific code Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 06/17] powerpc/pseries: lparcfg don't include slb_size line in radix mode Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 07/17] powerpc/64s: move THP trace point creation out of hash specific file Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 08/17] powerpc/64s: Make flush_and_reload_slb a no-op when radix is enabled Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 09/17] powerpc/64s: move page size definitions from hash specific file Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 10/17] powerpc/64s: Rename hash_hugetlbpage.c to hugetlbpage.c Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 11/17] powerpc/64: pcpu setup avoid reading mmu_linear_psize on 64e or radix Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 12/17] powerpc: make memremap_compat_align 64s-only Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 13/17] powerpc/64e: remove mmu_linear_psize Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 14/17] powerpc/64s: Fix radix MMU when MMU_FTR_HPTE_TABLE is clear Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 15/17] powerpc/64s: Make hash MMU support configurable Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 16/17] powerpc/64s: Move hash MMU support code under CONFIG_PPC_64S_HASH_MMU Nicholas Piggin
2021-11-25 19:28 ` kernel test robot
2021-11-25 12:50 ` [PATCH v4 17/17] powerpc/microwatt: add POWER9_CPU, clear PPC_64S_HASH_MMU Nicholas Piggin
2021-11-25 16:35 ` [PATCH v4 00/17] powerpc: Make hash MMU code build configurable Christophe Leroy
2021-11-25 17:35 ` Christophe Leroy
2021-11-26 0:55 ` Nicholas Piggin [this message]
2021-11-26 7:20 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1637887917.uatiybce4e.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).