From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E7A5C433EF for ; Wed, 1 Dec 2021 06:01:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4J3pPn007Fz3cQs for ; Wed, 1 Dec 2021 17:01:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=EMHBw0e/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1029; helo=mail-pj1-x1029.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=EMHBw0e/; dkim-atps=neutral Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4J3pP14TmRz2yP9 for ; Wed, 1 Dec 2021 17:01:07 +1100 (AEDT) Received: by mail-pj1-x1029.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so459311pjb.1 for ; Tue, 30 Nov 2021 22:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=p+h1Ci/5eM23w48d10JZjE3E1+seAEm4EAViYXAETPQ=; b=EMHBw0e/vGvcPCdRzYL0MfE/37rgfduTDk9qLZ0R3VsAFToDzsY/A2ZyZ55i+ws7OC 0NL1oAJDxinVH4PZ9cqcxaQji1byUi4VBBM5seBz+tqYgz/yhelWO7a1trjSCybQ3lcc pYciQPv0k6n7Hwx2dgGPY2QSQxnkTHGPCPmxujPrXi76r1YIneRk3+Dos1ye+XfYOd2i VvBSarZjbLT9XBYH2mkWnOmV0bD/AoTKSuoMmLv+z7Tqnq4tqUwJ+nlHapIl9iQR9Sfq cQMSM+DZl4T0/eKs/Idrs599QBFIKXg03quXFFHV1VsZovNYt23a2gDS0ak+hDJvHwwB 28QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=p+h1Ci/5eM23w48d10JZjE3E1+seAEm4EAViYXAETPQ=; b=yBGsIXaxJa2MbDpiGDRjPeawD9PaJuyDUSaC73eb0zYkAZY4qLKhixDFAeoZf1TSk9 qBYlSOiPeKry8P6ud0BcRwHCAAUGmMJk2DZXUdzm54+YTTeZkF0Vzpiv5UJ28zlnLXMt it5ktwrWl219KcnQ5Yu3xXyNXRM27RGcDPfZBFiak2g1uvPRP93pkfzhIKQuTkuZcCsx jW/2Q8y0R20zMaDuKo7/fP1TZ6nvC4PJnw5fnSl9MO0K9lWSO2WWJsVfS1xWdgxy0MW+ lxcTV0szLfaJVAKdXTjKa0VPRxB+G17ABS3oiOMfCyqJdDOonosxCIa1uaFMzTDtOI7J t8VA== X-Gm-Message-State: AOAM532UrLG8n34nnKFpshLiGvUMQ3ioTlu+l9M/QnqPkXI+rpVAOny7 srsnYOWAReKOfDKI2ZM5kGE= X-Google-Smtp-Source: ABdhPJyVjW0vwT2dzIxQQRiiYKpz/cJyyLjekGgJiHEOZGOEmsuBfOcYzGxu/rMy5VtmahhvpyRyHA== X-Received: by 2002:a17:902:c202:b0:142:2441:aa25 with SMTP id 2-20020a170902c20200b001422441aa25mr4897937pll.68.1638338464453; Tue, 30 Nov 2021 22:01:04 -0800 (PST) Received: from localhost (115-64-213-93.static.tpgi.com.au. [115.64.213.93]) by smtp.gmail.com with ESMTPSA id p10sm22499478pff.173.2021.11.30.22.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 22:01:03 -0800 (PST) Date: Wed, 01 Dec 2021 16:00:58 +1000 From: Nicholas Piggin Subject: Re: [PATCH v2 rebased 5/9] powerpc/mm: Call radix__arch_get_unmapped_area() from arch_get_unmapped_area() To: alex@ghiti.fr, Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , Paul Mackerras References: <6ba86b0ef347c04a6c4e475c059f486b0db170ec.1637862579.git.christophe.leroy@csgroup.eu> In-Reply-To: <6ba86b0ef347c04a6c4e475c059f486b0db170ec.1637862579.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1638338152.00yryi8b39.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Christophe Leroy's message of November 26, 2021 3:52 am: > Instead of setting mm->get_unmapped_area() to either > arch_get_unmapped_area() or radix__arch_get_unmapped_area(), > always set it to arch_get_unmapped_area() and call > radix__arch_get_unmapped_area() from there when radix is enabled. >=20 > To keep radix__arch_get_unmapped_area() static, move it to slice.c >=20 > Do the same with radix__arch_get_unmapped_area_topdown() Same comment with this one really. It would be better if we can reuse generic code. Thanks, Nick