From: Nicholas Piggin <npiggin@gmail.com>
To: Fabiano Rosas <farosas@linux.ibm.com>, kvm-ppc@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] KVM: PPC: Book3S HV: Check return value of kvmppc_radix_init
Date: Sat, 25 Dec 2021 20:17:16 +1000 [thread overview]
Message-ID: <1640427422.4ftxfv81m7.astroid@bobo.none> (raw)
In-Reply-To: <20211223211931.3560887-2-farosas@linux.ibm.com>
Excerpts from Fabiano Rosas's message of December 24, 2021 7:19 am:
> The return of the function is being shadowed by the call to
> kvmppc_uvmem_init.
>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> Fixes: ca9f4942670c ("KVM: PPC: Book3S HV: Support for running secure guests")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> arch/powerpc/kvm/book3s_hv.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 7b74fc0a986b..9f4765951733 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -6098,8 +6098,11 @@ static int kvmppc_book3s_init_hv(void)
> if (r)
> return r;
>
> - if (kvmppc_radix_possible())
> + if (kvmppc_radix_possible()) {
> r = kvmppc_radix_init();
> + if (r)
> + return r;
> + }
>
> r = kvmppc_uvmem_init();
> if (r < 0)
> --
> 2.33.1
>
>
next prev parent reply other threads:[~2021-12-25 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 21:19 [PATCH 0/3] KVM: PPC: KVM module exit fixes Fabiano Rosas
2021-12-23 21:19 ` [PATCH 1/3] KVM: PPC: Book3S HV: Check return value of kvmppc_radix_init Fabiano Rosas
2021-12-25 10:17 ` Nicholas Piggin [this message]
2021-12-23 21:19 ` [PATCH 2/3] KVM: PPC: Book3S HV: Delay setting of kvm ops Fabiano Rosas
2021-12-25 10:19 ` Nicholas Piggin
2022-01-11 14:43 ` Fabiano Rosas
2021-12-23 21:19 ` [PATCH 3/3] KVM: PPC: Book3S HV: Free allocated memory if module init fails Fabiano Rosas
2021-12-25 10:22 ` Nicholas Piggin
2022-02-18 2:09 ` [PATCH 0/3] KVM: PPC: KVM module exit fixes Michael Ellerman
2022-03-12 10:42 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1640427422.4ftxfv81m7.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=farosas@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).