From: patchwork-bot+netdevbpf@kernel.org
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH] net: apple: mace: Fix build since dev_addr constification
Date: Fri, 14 Jan 2022 11:30:10 +0000 [thread overview]
Message-ID: <164215981057.30922.17945470510196780677.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220114031252.2419042-1-mpe@ellerman.id.au>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 14 Jan 2022 14:12:52 +1100 you wrote:
> Since commit adeef3e32146 ("net: constify netdev->dev_addr") the mace
> driver no longer builds with various errors (pmac32_defconfig):
>
> linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_probe’:
> linux/drivers/net/ethernet/apple/mace.c:170:20: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)j)’
> 170 | dev->dev_addr[j] = rev ? bitrev8(addr[j]): addr[j];
> | ^
> linux/drivers/net/ethernet/apple/mace.c: In function ‘mace_reset’:
> linux/drivers/net/ethernet/apple/mace.c:349:32: warning: passing argument 2 of ‘__mace_set_address’ discards ‘const’ qualifier from pointer target type
> 349 | __mace_set_address(dev, dev->dev_addr);
> | ~~~^~~~~~~~~~
> linux/drivers/net/ethernet/apple/mace.c:93:62: note: expected ‘void *’ but argument is of type ‘const unsigned char *’
> 93 | static void __mace_set_address(struct net_device *dev, void *addr);
> | ~~~~~~^~~~
> linux/drivers/net/ethernet/apple/mace.c: In function ‘__mace_set_address’:
> linux/drivers/net/ethernet/apple/mace.c:388:36: error: assignment of read-only location ‘*(dev->dev_addr + (sizetype)i)’
> 388 | out_8(&mb->padr, dev->dev_addr[i] = p[i]);
> | ^
>
> [...]
Here is the summary with links:
- net: apple: mace: Fix build since dev_addr constification
https://git.kernel.org/netdev/net/c/6c8dc12cd925
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-01-14 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 3:12 [PATCH] net: apple: mace: Fix build since dev_addr constification Michael Ellerman
2022-01-14 4:21 ` Jakub Kicinski
2022-01-14 11:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164215981057.30922.17945470510196780677.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox