From: Nicholas Piggin <npiggin@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"# 3.4.x" <stable@vger.kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] powerpc: fix build errors
Date: Fri, 25 Feb 2022 10:23:07 +1000 [thread overview]
Message-ID: <1645748553.sa2ewgy7dr.astroid@bobo.none> (raw)
In-Reply-To: <20220224172948.GN614@gate.crashing.org>
Excerpts from Segher Boessenkool's message of February 25, 2022 3:29 am:
> On Thu, Feb 24, 2022 at 09:13:25PM +1000, Nicholas Piggin wrote:
>> Excerpts from Arnd Bergmann's message of February 24, 2022 8:20 pm:
>> > Again, there should be a minimum number of those .machine directives
>> > in inline asm as well, which tends to work out fine as long as the
>> > entire kernel is built with the correct -march= option for the minimum
>> > supported CPU, and stays away from inline asm that requires a higher
>> > CPU level.
>>
>> There's really no advantage to them, and they're ugly and annoying
>> and if we applied the concept consistently for all asm they would grow
>> to a very large number.
>
> The advantage is that you get machine code that *works*. There are
> quite a few mnemonics that translate to different instructions with
> different machine options! We like to get the intended instructions
> instead of something that depends on what assembler options the user
> has passed behind our backs.
>
>> The idea they'll give you good static checking just doesn't really
>> pan out.
>
> That never was a goal of this at all.
>
> -many was very problematical for GCC itself. We no longer use it.
You have the wrong context. We're not talking about -many vs .machine
here.
Thanks,
Nick
next prev parent reply other threads:[~2022-02-25 0:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:58 [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Anders Roxell
2022-02-23 13:58 ` [PATCH 2/3] powerpc: fix build errors Anders Roxell
2022-02-23 15:21 ` Segher Boessenkool
2022-02-24 2:54 ` Nicholas Piggin
2022-02-24 5:05 ` Nicholas Piggin
2022-02-24 8:55 ` Arnd Bergmann
2022-02-24 10:11 ` Nicholas Piggin
2022-02-24 10:20 ` Arnd Bergmann
2022-02-24 11:13 ` Nicholas Piggin
2022-02-24 17:29 ` Segher Boessenkool
2022-02-25 0:23 ` Nicholas Piggin [this message]
2022-02-25 22:28 ` Segher Boessenkool
2022-02-26 0:07 ` Nicholas Piggin
2022-02-24 17:12 ` Segher Boessenkool
2022-02-25 0:32 ` Nicholas Piggin
2022-02-25 8:33 ` Arnd Bergmann
2022-02-25 10:51 ` Nicholas Piggin
2022-02-25 22:33 ` Segher Boessenkool
2022-02-24 12:39 ` Michael Ellerman
2022-02-24 16:12 ` Anders Roxell
2022-02-24 17:37 ` Segher Boessenkool
2022-02-23 13:58 ` [PATCH 3/3] powerpc: lib: sstep: " Anders Roxell
2022-02-23 15:27 ` Segher Boessenkool
2022-02-24 2:40 ` [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1645748553.sa2ewgy7dr.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=segher@kernel.crashing.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).