From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Sathvika Vasireddy <sv@linux.ibm.com>
Cc: "aik@ozlabs.ru" <aik@ozlabs.ru>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>
Subject: Re: [RFC PATCH 2/3] objtool: Enable and implement 'mcount' subcommand
Date: Mon, 21 Mar 2022 15:18:47 +0530 [thread overview]
Message-ID: <1647855901.ds85pb94ut.naveen@linux.ibm.com> (raw)
In-Reply-To: <b06bb9bc-22d1-acce-fe68-c7c4cb7c15b5@csgroup.eu>
Christophe Leroy wrote:
>
>
> Le 21/03/2022 à 09:19, Naveen N. Rao a écrit :
>> Christophe Leroy wrote:
>>
>> We don't enable ftrace for vdso, so I suspect objtool run above will be
>> a no-op. This needs to be confirmed, of course.
>>
>
> I just checked without the series: recordmcount isn't run for VDSO, so
> objtool shouldn't be run either when the series is applied.
Agree. I was only pointing out that it would be harmless, but it is good
to ensure objtool is skipped for files/directories where ftrace isn't
enabled. recordmcount keys off the presence of CC_FLAGS_FTRACE, and we
should do the same for 'objtool --mcount'.
- Naveen
next prev parent reply other threads:[~2022-03-21 9:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 10:51 [RFC PATCH 0/3] objtool: Add mcount sub-command Sathvika Vasireddy
2022-03-18 10:51 ` [RFC PATCH 1/3] objtool: Move common code to utils.c Sathvika Vasireddy
2022-03-23 18:02 ` Miroslav Benes
2022-03-18 10:51 ` [RFC PATCH 2/3] objtool: Enable and implement 'mcount' subcommand Sathvika Vasireddy
2022-03-21 7:06 ` Christophe Leroy
2022-03-21 8:19 ` Naveen N. Rao
2022-03-21 8:26 ` Christophe Leroy
2022-03-21 9:48 ` Naveen N. Rao [this message]
2022-03-18 10:51 ` [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions Sathvika Vasireddy
2022-03-18 12:26 ` Peter Zijlstra
2022-03-18 13:59 ` Christophe Leroy
2022-03-21 2:27 ` Michael Ellerman
2022-03-21 6:47 ` Christophe Leroy
2022-03-21 7:46 ` Christophe Leroy
2022-03-21 7:56 ` Christophe Leroy
2022-03-21 8:30 ` Christophe Leroy
2022-03-21 8:59 ` Christophe Leroy
2022-03-26 7:58 ` Christophe Leroy
2022-03-21 6:25 ` Naveen N. Rao
2022-03-27 9:09 ` Christophe Leroy
2022-03-28 19:59 ` Josh Poimboeuf
2022-03-28 20:14 ` Peter Zijlstra
2022-03-28 20:15 ` Peter Zijlstra
2022-03-28 20:21 ` Josh Poimboeuf
2022-03-29 12:01 ` Michael Ellerman
2022-03-29 17:32 ` Christophe Leroy
2022-03-30 4:26 ` Josh Poimboeuf
2022-03-30 18:40 ` Naveen N. Rao
2022-05-12 14:52 ` Christophe Leroy
2022-05-12 15:12 ` Josh Poimboeuf
2022-05-21 9:38 ` Christophe Leroy
2022-05-21 10:57 ` Peter Zijlstra
2022-05-23 5:39 ` Naveen N. Rao
2022-03-19 1:35 ` [RFC PATCH 0/3] objtool: Add mcount sub-command Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647855901.ds85pb94ut.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=aik@ozlabs.ru \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).