From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70BC1C433EF for ; Thu, 28 Apr 2022 17:32:09 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Kq2k00cCLz3bpF for ; Fri, 29 Apr 2022 03:32:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=amizwVNm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=naveen.n.rao@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=amizwVNm; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Kq2jC3WHsz2yJ5 for ; Fri, 29 Apr 2022 03:31:27 +1000 (AEST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23SGwn2g036539; Thu, 28 Apr 2022 17:31:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : subject : to : cc : references : in-reply-to : mime-version : message-id : content-type : content-transfer-encoding; s=pp1; bh=UOJdp1TCQXMGKaap1xfqCqRJHtLXn6tqJXwjCeVYGO8=; b=amizwVNmUHiCyAox1AE/m9UvocObZnZcei+1XD4AzG1xgMBnFnmPeAWx4xQpz7rvPtLA GIhR9fIc6kB82PiJrQU/sZ7pahoXw89ODmM8NyijjHHlrZbrxaJqZAygK6wtq7CWPpMV tq0WQDeX1+J6tS+UKbJppenwx0vcWRDffzQ9i8wKAfDAnm+oEDB3ePgmtL+PQEVu+lcK 6gqe5vhQBPgJiJeXfQg2m8yVCGGyk5Nubmfto5q0pdKQTeDg7M2IC5f1NWi/Y9U1nIBn XAQWRZSFcwQLGjhG/NQfTxD1QFno5L+FO00eJotsf9Nt74FI9OT9XYEET1qDzqEKB2m/ YA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fqvapd74u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 17:31:18 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 23SHRUXN017159; Thu, 28 Apr 2022 17:31:17 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fqvapd745-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 17:31:17 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23SHCmXU015445; Thu, 28 Apr 2022 17:31:15 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3fm938yu9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Apr 2022 17:31:15 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23SHI6NG41091346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Apr 2022 17:18:06 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E64FAE051; Thu, 28 Apr 2022 17:31:13 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A2DCAE045; Thu, 28 Apr 2022 17:31:12 +0000 (GMT) Received: from localhost (unknown [9.43.8.21]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 28 Apr 2022 17:31:12 +0000 (GMT) Date: Thu, 28 Apr 2022 23:01:09 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols To: Steven Rostedt References: <1b9566f0e7185fb8fd8ef2535add7a081501ccc8.1651047542.git.naveen.n.rao@linux.vnet.ibm.com> <20220427095415.594e5120@gandalf.local.home> <1651129169.fpixr00hgx.naveen@linux.ibm.com> <20220428100602.7b215e52@gandalf.local.home> In-Reply-To: <20220428100602.7b215e52@gandalf.local.home> MIME-Version: 1.0 User-Agent: astroid/4d6b06ad (https://github.com/astroidmail/astroid) Message-Id: <1651166901.se7n53e6x9.naveen@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _vVoo22SHJ60vhyVlx5kYl9ko3bWX2gi X-Proofpoint-GUID: i3xUn0t9kbsH7PTUXToGLXIlrphwetHx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-28_02,2022-04-28_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=0 mlxlogscore=497 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204280105 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, Nick Desaulniers , linux-kernel@vger.kernel.org, Nathan Chancellor , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Steven Rostedt wrote: > On Thu, 28 Apr 2022 13:15:22 +0530 > "Naveen N. Rao" wrote: >=20 >> Indeed, plain old -pg will be a problem. I'm not sure there is a generic= =20 >> way to address this. I suppose architectures will have to validate the=20 >> mcount locations, something like this? >=20 > Perhaps another solution is to make the mcount locations after the linkin= g > is done. The main downside to that is that it takes time to go over the > entire vmlinux, and will slow down a compile that only modified a couple = of > files. Yes, and I think that is also very useful with LTO. So, that would be=20 good to consider in the longer term. For now, I have posted a v2 of this series with your comments addressed. =20 It is working well in my tests on powerpc in the different=20 configurations, including the older elf v1 abi with -pg. If it looks ok=20 to you, we can go with this approach for now. Thanks, Naveen