From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46455C54FCB for ; Mon, 27 Apr 2020 15:18:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D8E22054F for ; Mon, 27 Apr 2020 15:18:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ixjl1U9Z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C1t0lWdR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D8E22054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 499pM100TbzDqTD for ; Tue, 28 Apr 2020 01:18:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.61; helo=us-smtp-delivery-1.mimecast.com; envelope-from=pbonzini@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ixjl1U9Z; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C1t0lWdR; dkim-atps=neutral Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 499pHw5qMxzDqSf for ; Tue, 28 Apr 2020 01:15:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588000536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSpYzJ8vruskzw1ixWuPTFKODIOCb1DdC0Y5Ypx1fB0=; b=Ixjl1U9ZxAd7CT3hUfVBj4OC3cNpxodUZOfnDT/R+PiEaqt/AILrKzUj5Eo/rzHioy9Oln cvJLzIAKJ6wHxC5CCF4L4yKtPq/EaBFl8TJ9vWTotACZe3HuIK/3lALMrWYOMCjppl2WFY 7T3/PCaVB0U3AZ/R1FovAdsEF10h418= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588000537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSpYzJ8vruskzw1ixWuPTFKODIOCb1DdC0Y5Ypx1fB0=; b=C1t0lWdRGCeEyE/zkw5T0M547DL4lmRko57KvL5UpPSx/C1PdizICZDblecVXdwVvyf5o9 2axUU8XKTVR8Zfho2kRLCJOkZmYdnmPhCCDGpEMr6+m79FEJ3EQ06rVoINOvEYUuBWFa6Q 968t8uvr1Ys6orN8ybSG3hBcKN0Z1CI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-9nmBXQDwNAidcCBKCYK7vg-1; Mon, 27 Apr 2020 11:15:34 -0400 X-MC-Unique: 9nmBXQDwNAidcCBKCYK7vg-1 Received: by mail-wr1-f69.google.com with SMTP id r11so10657529wrx.21 for ; Mon, 27 Apr 2020 08:15:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eSpYzJ8vruskzw1ixWuPTFKODIOCb1DdC0Y5Ypx1fB0=; b=uDdIIWXXqS4fYqCJ7+fk6ofKKJVfpz1ONHbFlP7E4Iadczy4hsDOH0f9gg5GqGlYM9 dnvGjRNLDeGFZFRd5ov4O8Cfxy8EBmgJhkruaWRRn/SgAdI++okwVH4xD9bHAJPDhjcB vwARnJQUfiiKgJN9RqTWeftk/ck+vHYUS/2TBenD8w3brBN01EEhVcMcjmzExUlWfy3I SYaCoa1q01WrMNYtHiMFzUDKp76ESh7MKgmlL30aA+ft9a7QYzk7MYFx7P8U09rw3hFQ YA5GBmjTOGVvnRFPs42EBr9+tBYX6ncE1z8c6kyrb/+RpAlfrHMupHfKGkrbAi8vv36S GNrQ== X-Gm-Message-State: AGi0Puaovtu9YJCDDtM1QPoxrIIKGG7XzEJB1mq4d2oNl4bi2qPa5Duu oFc9wUwwZfv+ky2DNF0itxrevWcq1VMGx0F+ar15FmnZ5U4F+QQ9h9ggjoVPV+e+CZylbaAkvkZ QkO22c5P/7pVVsggCQm7kKk6kXQ== X-Received: by 2002:a5d:670d:: with SMTP id o13mr29924481wru.29.1588000533364; Mon, 27 Apr 2020 08:15:33 -0700 (PDT) X-Google-Smtp-Source: APiQypK+T+6Aj+dLlxq4HhKDwXzdqmOqUdriVVov3jgAPiPujwYcHZ4fNtTJwlwzd9NWqPh44afp5Q== X-Received: by 2002:a5d:670d:: with SMTP id o13mr29924444wru.29.1588000533150; Mon, 27 Apr 2020 08:15:33 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ac19:d1fb:3f5f:d54f? ([2001:b07:6468:f312:ac19:d1fb:3f5f:d54f]) by smtp.gmail.com with ESMTPSA id n6sm23226378wrs.81.2020.04.27.08.15.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 08:15:32 -0700 (PDT) Subject: Re: [PATCH v2 6/7] debugfs: switch to simplefs inode creation API To: Emanuele Giuseppe Esposito , linux-fsdevel@vger.kernel.org References: <20200421135119.30007-1-eesposit@redhat.com> <20200421135741.30657-4-eesposit@redhat.com> From: Paolo Bonzini Message-ID: <167ebece-2e50-5186-3a42-2fa491fcb8a5@redhat.com> Date: Mon, 27 Apr 2020 17:15:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200421135741.30657-4-eesposit@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , David Airlie , dri-devel@lists.freedesktop.org, Christoph Hellwig , Andrew Donnellan , linux-scsi@vger.kernel.org, James Morris , "Serge E. Hallyn" , Daniel Vetter , Arnd Bergmann , "James E.J. Bottomley" , Maarten Lankhorst , Maxime Ripard , "Manoj N. Kumar" , Alexander Viro , "Matthew R. Ochs" , Uma Krishnan , John Johansen , "Martin K. Petersen" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Thomas Zimmermann , Frederic Barrat , linuxppc-dev@lists.ozlabs.org, Joel Becker Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 21/04/20 15:57, Emanuele Giuseppe Esposito wrote: > - inode = debugfs_get_inode(dentry->d_sb); You're not removing debugfs_get_inode so I think you're going to get a warning (same in tracefs)? You can wait a few more days for reviews and/or Acked-bys (especially for patches 6 and 7) and then post v3. Since the touch-everything patch (#2) has already been reviewed, and it's mechanical and not introducing any semantic change, you can probably reduce the To/Cc list to filesystem, debugfs and tracefs maintainers. Thanks, Paolo