* [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void
@ 2023-07-10 7:19 Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 5/8] net: fs_enet: " Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-07-10 7:19 UTC (permalink / raw)
To: Madalin Bucur, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maciej Fijalkowski, Wei Fang, Simon Horman,
Nicolas Ferre, Marc Kleine-Budde, Michal Kubiak, Rob Herring,
Pantelis Antoniou, Claudiu Manoil, Li Yang
Cc: Sean Anderson, netdev, Russell King, Shenwei Wang, Clark Wang,
NXP Linux Team, kernel, linuxppc-dev
Hello,
v2 of this series was sent in June[1], code changes since then only affect
patch #1 where the dev_err invocation was adapted to emit the error code of
dpaa_fq_free(). Thanks for feedback by Maciej Fijalkowski and Russell King.
Other than that I added Reviewed-by tags for Simon Horman and Wei Fang and
rebased to v6.5-rc1.
There is only one dependency in this series: Patch #2 depends on patch
#1.
Best regards
Uwe
[1] https://lore.kernel.org/netdev/20230606162829.166226-1-u.kleine-koenig@pengutronix.de
Uwe Kleine-König (8):
net: dpaa: Improve error reporting
net: dpaa: Convert to platform remove callback returning void
net: fec: Convert to platform remove callback returning void
net: fman: Convert to platform remove callback returning void
net: fs_enet: Convert to platform remove callback returning void
net: fsl_pq_mdio: Convert to platform remove callback returning void
net: gianfar: Convert to platform remove callback returning void
net: ucc_geth: Convert to platform remove callback returning void
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 9 +++++----
drivers/net/ethernet/freescale/fec_main.c | 5 ++---
drivers/net/ethernet/freescale/fec_mpc52xx.c | 6 ++----
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 6 ++----
drivers/net/ethernet/freescale/fman/mac.c | 5 ++---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 5 ++---
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 6 ++----
drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 6 ++----
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 6 ++----
drivers/net/ethernet/freescale/gianfar.c | 6 ++----
drivers/net/ethernet/freescale/ucc_geth.c | 6 ++----
11 files changed, 25 insertions(+), 41 deletions(-)
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next v3 5/8] net: fs_enet: Convert to platform remove callback returning void
2023-07-10 7:19 [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void Uwe Kleine-König
@ 2023-07-10 7:19 ` Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 8/8] net: ucc_geth: " Uwe Kleine-König
2023-07-12 3:30 ` [PATCH net-next v3 0/8] net: freescale: " patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-07-10 7:19 UTC (permalink / raw)
To: Pantelis Antoniou, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Simon Horman, Michal Kubiak, linuxppc-dev, kernel, netdev
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 5 ++---
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 6 ++----
drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 6 ++----
3 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8844a9a04fcf..f9f5b28cc72e 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1051,7 +1051,7 @@ static int fs_enet_probe(struct platform_device *ofdev)
return ret;
}
-static int fs_enet_remove(struct platform_device *ofdev)
+static void fs_enet_remove(struct platform_device *ofdev)
{
struct net_device *ndev = platform_get_drvdata(ofdev);
struct fs_enet_private *fep = netdev_priv(ndev);
@@ -1066,7 +1066,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
if (of_phy_is_fixed_link(ofdev->dev.of_node))
of_phy_deregister_fixed_link(ofdev->dev.of_node);
free_netdev(ndev);
- return 0;
}
static const struct of_device_id fs_enet_match[] = {
@@ -1113,7 +1112,7 @@ static struct platform_driver fs_enet_driver = {
.of_match_table = fs_enet_match,
},
.probe = fs_enet_probe,
- .remove = fs_enet_remove,
+ .remove_new = fs_enet_remove,
};
#ifdef CONFIG_NET_POLL_CONTROLLER
diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
index 21de56345503..91a69fc2f7c2 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
@@ -192,7 +192,7 @@ static int fs_enet_mdio_probe(struct platform_device *ofdev)
return ret;
}
-static int fs_enet_mdio_remove(struct platform_device *ofdev)
+static void fs_enet_mdio_remove(struct platform_device *ofdev)
{
struct mii_bus *bus = platform_get_drvdata(ofdev);
struct bb_info *bitbang = bus->priv;
@@ -201,8 +201,6 @@ static int fs_enet_mdio_remove(struct platform_device *ofdev)
free_mdio_bitbang(bus);
iounmap(bitbang->dir);
kfree(bitbang);
-
- return 0;
}
static const struct of_device_id fs_enet_mdio_bb_match[] = {
@@ -219,7 +217,7 @@ static struct platform_driver fs_enet_bb_mdio_driver = {
.of_match_table = fs_enet_mdio_bb_match,
},
.probe = fs_enet_mdio_probe,
- .remove = fs_enet_mdio_remove,
+ .remove_new = fs_enet_mdio_remove,
};
module_platform_driver(fs_enet_bb_mdio_driver);
diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
index 59a8f0bd0f5c..1910df250c33 100644
--- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
+++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c
@@ -187,7 +187,7 @@ static int fs_enet_mdio_probe(struct platform_device *ofdev)
return ret;
}
-static int fs_enet_mdio_remove(struct platform_device *ofdev)
+static void fs_enet_mdio_remove(struct platform_device *ofdev)
{
struct mii_bus *bus = platform_get_drvdata(ofdev);
struct fec_info *fec = bus->priv;
@@ -196,8 +196,6 @@ static int fs_enet_mdio_remove(struct platform_device *ofdev)
iounmap(fec->fecp);
kfree(fec);
mdiobus_free(bus);
-
- return 0;
}
static const struct of_device_id fs_enet_mdio_fec_match[] = {
@@ -220,7 +218,7 @@ static struct platform_driver fs_enet_fec_mdio_driver = {
.of_match_table = fs_enet_mdio_fec_match,
},
.probe = fs_enet_mdio_probe,
- .remove = fs_enet_mdio_remove,
+ .remove_new = fs_enet_mdio_remove,
};
module_platform_driver(fs_enet_fec_mdio_driver);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next v3 8/8] net: ucc_geth: Convert to platform remove callback returning void
2023-07-10 7:19 [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 5/8] net: fs_enet: " Uwe Kleine-König
@ 2023-07-10 7:19 ` Uwe Kleine-König
2023-07-12 3:30 ` [PATCH net-next v3 0/8] net: freescale: " patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-07-10 7:19 UTC (permalink / raw)
To: Li Yang, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, Michal Kubiak, linuxppc-dev, kernel, Simon Horman
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/ethernet/freescale/ucc_geth.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 7a4cb4f07c32..2b3a15f24e7c 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3753,7 +3753,7 @@ static int ucc_geth_probe(struct platform_device* ofdev)
return err;
}
-static int ucc_geth_remove(struct platform_device* ofdev)
+static void ucc_geth_remove(struct platform_device* ofdev)
{
struct net_device *dev = platform_get_drvdata(ofdev);
struct ucc_geth_private *ugeth = netdev_priv(dev);
@@ -3767,8 +3767,6 @@ static int ucc_geth_remove(struct platform_device* ofdev)
of_node_put(ugeth->ug_info->phy_node);
kfree(ugeth->ug_info);
free_netdev(dev);
-
- return 0;
}
static const struct of_device_id ucc_geth_match[] = {
@@ -3787,7 +3785,7 @@ static struct platform_driver ucc_geth_driver = {
.of_match_table = ucc_geth_match,
},
.probe = ucc_geth_probe,
- .remove = ucc_geth_remove,
+ .remove_new = ucc_geth_remove,
.suspend = ucc_geth_suspend,
.resume = ucc_geth_resume,
};
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void
2023-07-10 7:19 [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 5/8] net: fs_enet: " Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 8/8] net: ucc_geth: " Uwe Kleine-König
@ 2023-07-12 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-12 3:30 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: madalin.bucur, simon.horman, edumazet, robh, sean.anderson, linux,
shenwei.wang, xiaoning.wang, linux-imx, kuba, pabeni,
maciej.fijalkowski, claudiu.manoil, wei.fang, michal.kubiak,
netdev, nicolas.ferre, leoyang.li, kernel, mkl, linuxppc-dev,
davem
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 10 Jul 2023 09:19:38 +0200 you wrote:
> Hello,
>
> v2 of this series was sent in June[1], code changes since then only affect
> patch #1 where the dev_err invocation was adapted to emit the error code of
> dpaa_fq_free(). Thanks for feedback by Maciej Fijalkowski and Russell King.
> Other than that I added Reviewed-by tags for Simon Horman and Wei Fang and
> rebased to v6.5-rc1.
>
> [...]
Here is the summary with links:
- [net-next,v3,1/8] net: dpaa: Improve error reporting
https://git.kernel.org/netdev/net-next/c/1e679b957ae2
- [net-next,v3,2/8] net: dpaa: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/9c3ddc44d0c0
- [net-next,v3,3/8] net: fec: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/12d6cc19f29b
- [net-next,v3,4/8] net: fman: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/4875b2a362e9
- [net-next,v3,5/8] net: fs_enet: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/ead29c5e0888
- [net-next,v3,6/8] net: fsl_pq_mdio: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/f833635589ae
- [net-next,v3,7/8] net: gianfar: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/4be0ebc33f39
- [net-next,v3,8/8] net: ucc_geth: Convert to platform remove callback returning void
https://git.kernel.org/netdev/net-next/c/ae18facf566c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-12 3:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 7:19 [PATCH net-next v3 0/8] net: freescale: Convert to platform remove callback returning void Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 5/8] net: fs_enet: " Uwe Kleine-König
2023-07-10 7:19 ` [PATCH net-next v3 8/8] net: ucc_geth: " Uwe Kleine-König
2023-07-12 3:30 ` [PATCH net-next v3 0/8] net: freescale: " patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).