From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: david-b@pacbell.net, spi-devel-general@lists.sourceforge.net,
fabrizio.garetto@gmail.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 3/5] of-bindings: Add binding documentation for SPI busses and devices
Date: Sat, 5 Jul 2008 01:36:58 +0200 [thread overview]
Message-ID: <1694b01b1b41f244e565298b430f021c@kernel.crashing.org> (raw)
In-Reply-To: <20080703010308.26187.23037.stgit@trillian.secretlab.ca>
> + The SPI master node requires the following properties:
> + - #address-cells - number of cells required to define a chip
> select
> + address on the SPI bus.
Hrm. Should this (and "reg" in the child node) be required for SPI
masters that have only one chip select?
> + - max-speed - (required) Maximum SPI clocking speed of
> device in Hz
The property name should include something "SPI", it's way too generic
otherwise.
> + - spi,cpol - (optional) Device requires inverse clock
> polarity
> + - spi,cpha - (optional) Device requires shifted clock phase
Don't abbr the property names, there's nothing wrong with longer names.
The names shouldn't start with "spi," either, "spi" isn't a vendor;
how about "spi-inverse-clock-polarity" or similar?
> + - linux,modalias - (optional, Linux specific) Force binding of
> SPI device
> + to a particular spi_device driver. Useful for changing
> + driver binding between spidev and a kernel SPI driver.
This is a temporary workaround I hope?
Segher
next prev parent reply other threads:[~2008-07-04 23:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 1:02 [PATCH v2 0/5] SPI OF bindings and mpc5200-spi driver Grant Likely
2008-07-03 1:02 ` [PATCH v2 1/5] spi: Change modalias from a pointer to a character array Grant Likely
2008-07-03 1:03 ` [PATCH v2 2/5] spi: split up spi_new_device() to allow two stage registration Grant Likely
2008-07-03 1:03 ` [PATCH v2 3/5] of-bindings: Add binding documentation for SPI busses and devices Grant Likely
2008-07-04 3:59 ` [PATCH v2 3/5] of-bindings: Add binding documentation for SPI bussesand devices Chen Gong
2008-07-04 4:05 ` Grant Likely
2008-07-04 23:36 ` Segher Boessenkool [this message]
2008-07-04 23:42 ` [PATCH v2 3/5] of-bindings: Add binding documentation for SPI busses and devices Grant Likely
2008-07-03 1:03 ` [PATCH v2 4/5] spi: Add OF binding support for SPI busses Grant Likely
2008-07-03 3:02 ` Jon Smirl
2008-07-12 5:21 ` Grant Likely
2008-07-04 3:54 ` Chen Gong
2008-07-04 4:17 ` Grant Likely
2008-07-03 1:03 ` [PATCH v2 5/5] powerpc/mpc5200: Add mpc5200-spi (non-PSC) device driver Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1694b01b1b41f244e565298b430f021c@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=fabrizio.garetto@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).