From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Victor Gallardo <vgallard@amcc.com>,
fkan@amcc.com, Arnd Bergmann <arnd@arndb.de>,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x
Date: Thu, 17 Jul 2008 05:19:44 +0200 [thread overview]
Message-ID: <16eddae5007f7d133818af806e22396d@kernel.crashing.org> (raw)
In-Reply-To: <20080716154646.GH24045@secretlab.ca>
>> Shouldn't it be enough to have a common compatible value in each
>> of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the
>> specific type unless you need to do something special?
>
> This is bad for the same reason that "amcc,44x-<blah>" compatible
> values
> are bad in device nodes. The definition of '*-44x-*' changes over
> time as
> new parts are added. Compatible values should always reflect an exact
> part number.
Erm, no.
"compatible" entries should always contain the real part name to reduce
the chance that separate parties come up with the same "compatible"
name for two different devices.
Other than that, the name really doesn't matter, it's just _some_
string that uniquely identifies a device; and the device bindings will
document what is what.
Of course, if no binding is written, it becomes a lot more important
that names have a sane value ;-)
Segher
next prev parent reply other threads:[~2008-07-17 3:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 5:33 [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x fkan
2008-07-16 11:50 ` Josh Boyer
2008-07-16 14:15 ` Grant Likely
2008-07-16 14:37 ` Josh Boyer
2008-07-16 15:43 ` Grant Likely
2008-07-17 3:15 ` Segher Boessenkool
2008-07-16 14:46 ` Arnd Bergmann
2008-07-16 15:46 ` Grant Likely
2008-07-16 22:58 ` Arnd Bergmann
2008-07-17 2:15 ` Josh Boyer
2008-07-17 3:24 ` Segher Boessenkool
2008-07-17 3:19 ` Segher Boessenkool [this message]
2008-07-18 22:31 ` Victor Gallardo
2008-07-19 13:44 ` Josh Boyer
2008-07-22 19:35 ` Victor Gallardo
2008-07-18 14:24 ` Stefan Roese
2008-07-18 22:24 ` Victor Gallardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16eddae5007f7d133818af806e22396d@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=fkan@amcc.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vgallard@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).