* [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64
@ 2005-12-21 12:12 Andi Kleen
2005-12-21 14:00 ` Simon Richter
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2005-12-21 12:12 UTC (permalink / raw)
To: benh, linuxppc-dev
For 2.6.15rc6-git2
Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.
Signed-off-by: Andi Kleen <ak@muc.de>
diff -u linux-2.6.15rc6git2/drivers/macintosh/Kconfig-o linux-2.6.15rc6git2/drivers/macintosh/Kconfig
--- linux-2.6.15rc6git2/drivers/macintosh/Kconfig-o 2005-12-21 12:27:45.000000000 +0100
+++ linux-2.6.15rc6git2/drivers/macintosh/Kconfig 2005-12-21 13:07:47.000000000 +0100
@@ -103,7 +103,7 @@
# on non-powerbook machines (but only on PMU based ones AFAIK)
config PMAC_BACKLIGHT
bool "Backlight control for LCD screens"
- depends on ADB_PMU && (BROKEN || !PPC64)
+ depends on ADB_PMU && !PPC64
help
Say Y here to build in code to manage the LCD backlight on a
Macintosh PowerBook. With this code, the backlight will be turned
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64
2005-12-21 12:12 [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64 Andi Kleen
@ 2005-12-21 14:00 ` Simon Richter
2005-12-21 19:37 ` Andi Kleen
0 siblings, 1 reply; 4+ messages in thread
From: Simon Richter @ 2005-12-21 14:00 UTC (permalink / raw)
To: Andi Kleen; +Cc: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Hi,
Andi Kleen wrote:
> Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.
> - depends on ADB_PMU && (BROKEN || !PPC64)
> + depends on ADB_PMU && !PPC64
That's why it's marked BROKEN, perhaps?
Simon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64
2005-12-21 14:00 ` Simon Richter
@ 2005-12-21 19:37 ` Andi Kleen
2005-12-21 22:20 ` Paul Mackerras
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2005-12-21 19:37 UTC (permalink / raw)
To: Simon Richter; +Cc: linuxppc-dev
On Wed, Dec 21, 2005 at 03:00:05PM +0100, Simon Richter wrote:
> Hi,
>
> Andi Kleen wrote:
>
> >Don't allow to set CONFIG_MAC_BACKLIGHT on pmac64. It won't compile.
>
> > - depends on ADB_PMU && (BROKEN || !PPC64)
> > + depends on ADB_PMU && !PPC64
>
> That's why it's marked BROKEN, perhaps?
It didn't work - i could select it.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64
2005-12-21 19:37 ` Andi Kleen
@ 2005-12-21 22:20 ` Paul Mackerras
0 siblings, 0 replies; 4+ messages in thread
From: Paul Mackerras @ 2005-12-21 22:20 UTC (permalink / raw)
To: Andi Kleen; +Cc: linuxppc-dev
Andi Kleen writes:
> It didn't work - i could select it.
Are you sure you don't have CONFIG_BROKEN=y?
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-12-21 22:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-21 12:12 [PATCH] Don't allow CONFIG_PMAC_BACKLIGHT on pmac64 Andi Kleen
2005-12-21 14:00 ` Simon Richter
2005-12-21 19:37 ` Andi Kleen
2005-12-21 22:20 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).