From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 04CB5DDFB0 for ; Thu, 31 May 2007 22:33:24 +1000 (EST) In-Reply-To: <7EA18FDD2DC2154AA3BD6D2F22A62A0E7EDA24@zch01exm23.fsl.freescale.net> References: <1180463004.13106.65.camel@ld0161-tx32> <7EA18FDD2DC2154AA3BD6D2F22A62A0E7EDA24@zch01exm23.fsl.freescale.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <1734C12F-4DE9-42A7-8C8F-B2800051DF7E@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH 3/3] Modified quirk_mpc8641_transparent() to initializebridge resources. Date: Thu, 31 May 2007 07:33:01 -0500 To: "Zang Roy-r61911" Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On May 31, 2007, at 1:48 AM, Zang Roy-r61911 wrote: >> >> On May 29, 2007, at 1:23 PM, Jon Loeliger wrote: >> >>> From: Jon Loeliger >>> >>> The 8641 RC poses as a transparent bridge, but does not >> implement the >>> IO_BASE or IO_LIMIT registers in the config space. This means that >>> the code which initializes the bridge resources ends up setting the >>> IO resources erroneously. >>> >>> This change initializes the RC bridge resources from the >> device tree. >>> >>> Signed-off-by: Andy Fleming >>> Signed-off-by: Jon Loeliger >> >> Can this be merged with Zhang's "Set RC of mpc8641 to transparent >> bridge for transfer legacy I/O access." patch since it pretty much >> supersedes it. > > I should be! > But why apply them sperately? > They refect differnet content and stage. For end user, they will only > see the unified code :-). The reason is that in the future someone may be doing a git-bisect to track down a bug and we like to have patches not break things if possible. - k