From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: Dave Young <dyoung@redhat.com>
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, vgoyal@redhat.com,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.
Date: Wed, 29 Jun 2016 18:09:46 -0300 [thread overview]
Message-ID: <1736656.LVyt5NrzWE@hactar> (raw)
In-Reply-To: <20160629194518.GA5488@dhcp-128-65.nay.redhat.com>
Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young:
> On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote:
> > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young:
> > > On 06/27/16 at 04:21pm, Dave Young wrote:
> > > Using one argument for both sounds more reasonable than using a
> > > separate
> > > argument for memory walk..
> >
> > I agree. This patch doesn't use a separate top_down argument, it's the
> > same patch I sent earlier except that the comments to struct kexec_buf
> > are in patch 2/9. What do you think?
>
> It looks good except one nitpick inline..
>
>
> > +/**
> > + * kexec_locate_mem_hole - find free memory to load segment or use in
> > purgatory
> It is not necessary to use only for purgatory load..
Ok, what about this?
/**
* kexec_locate_mem_hole - find free memory in a given kimage.
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2016-06-29 21:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 19:48 [PATCH v3 0/9] kexec_file_load implementation for PowerPC Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 1/9] kexec_file: Remove unused members from struct kexec_buf Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer Thiago Jung Bauermann
2016-06-22 10:20 ` Dave Young
2016-06-22 23:30 ` Thiago Jung Bauermann
2016-06-23 2:25 ` Dave Young
2016-06-28 22:18 ` Thiago Jung Bauermann
2016-06-29 19:47 ` Dave Young
2016-06-29 21:18 ` Thiago Jung Bauermann
2016-06-30 15:07 ` Dave Young
2016-06-30 15:49 ` Thiago Jung Bauermann
2016-06-30 16:42 ` Thiago Jung Bauermann
2016-06-30 21:43 ` Dave Young
2016-07-01 17:51 ` Thiago Jung Bauermann
2016-07-01 18:36 ` Dave Young
2016-07-01 20:02 ` Thiago Jung Bauermann
2016-07-01 20:31 ` Thiago Jung Bauermann
2016-07-05 0:55 ` Dave Young
2016-06-21 19:48 ` [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer Thiago Jung Bauermann
2016-06-22 10:18 ` Dave Young
2016-06-22 23:34 ` Thiago Jung Bauermann
2016-06-23 2:30 ` Dave Young
2016-06-23 5:44 ` Dave Young
2016-06-23 15:37 ` Thiago Jung Bauermann
2016-06-27 16:19 ` Dave Young
2016-06-27 16:37 ` Thiago Jung Bauermann
2016-06-27 16:51 ` Thiago Jung Bauermann
2016-06-27 20:21 ` Dave Young
2016-06-28 19:20 ` Dave Young
2016-06-28 22:18 ` Thiago Jung Bauermann
2016-06-29 19:45 ` Dave Young
2016-06-29 21:09 ` Thiago Jung Bauermann [this message]
2016-06-30 15:41 ` Dave Young
2016-06-30 16:08 ` Thiago Jung Bauermann
2016-06-30 21:37 ` Dave Young
2016-06-21 19:48 ` [PATCH v3 4/9] powerpc: Factor out relocation code from module_64.c to elf_util_64.c Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 5/9] powerpc: Generalize elf64_apply_relocate_add Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 6/9] powerpc: Add functions to read ELF files of any endianness Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 7/9] powerpc: Implement kexec_file_load Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 8/9] powerpc: Add support for loading ELF kernels with kexec_file_load Thiago Jung Bauermann
2016-06-21 19:48 ` [PATCH v3 9/9] powerpc: Add purgatory for kexec_file_load implementation Thiago Jung Bauermann
2016-06-22 13:29 ` [PATCH v3 0/9] kexec_file_load implementation for PowerPC Balbir Singh
2016-06-22 17:02 ` Thiago Jung Bauermann
2016-06-22 23:57 ` Balbir Singh
2016-06-23 16:44 ` Thiago Jung Bauermann
2016-06-23 22:33 ` Balbir Singh
2016-06-23 23:49 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1736656.LVyt5NrzWE@hactar \
--to=bauerman@linux.vnet.ibm.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).