From: Paul Mackerras <paulus@samba.org>
To: Eugene Surovegin <ebs@ebshome.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] lock PTE before updating it in 440/BookE page fault handler
Date: Tue, 28 Mar 2006 22:10:39 +1100 [thread overview]
Message-ID: <17449.6575.927844.106127@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060328075525.GA20801@gate.ebshome.net>
Eugene Surovegin writes:
> Fix 44x and BookE page fault handler to correctly lock PTE before
> trying to pte_update() it, otherwise this PTE might be swapped out
> after pte_present() check but before pte_uptdate() call, resulting in
> corrupted PTE. This can happen with enabled preemption and low memory
> condition.
That gives me this for an ARCH=powerpc 32-bit pmac build:
/home/paulus/kernel/powerpc/arch/powerpc/mm/pgtable_32.c:376: error: conflicting types for 'get_pteptr'
/home/paulus/kernel/powerpc/include/asm-ppc/pgtable.h:841: error: previous declaration of 'get_pteptr' was here
Paul.
next prev parent reply other threads:[~2006-03-28 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 20:26 Unsafe pte_update() in do_page_fault() (4xx and Book-E) Eugene Surovegin
2006-03-03 3:43 ` Benjamin Herrenschmidt
2006-03-03 3:55 ` Eugene Surovegin
2006-03-28 7:55 ` [PATCH] lock PTE before updating it in 440/BookE page fault handler Eugene Surovegin
2006-03-28 11:10 ` Paul Mackerras [this message]
2006-03-28 18:13 ` Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17449.6575.927844.106127@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=ebs@ebshome.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).