From: Paul Mackerras <paulus@samba.org>
To: vatsa@in.ibm.com
Cc: sri_vatsa_v@yahoo.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/4] tickless idle cpu: Skip ticks when CPU is idle
Date: Sat, 8 Apr 2006 09:40:42 +1000 [thread overview]
Message-ID: <17462.63610.217794.308786@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060407063131.GB22416@in.ibm.com>
Srivatsa Vaddagiri writes:
> diff -puN arch/powerpc/kernel/idle_power4.S~no_idle_hz arch/powerpc/kernel/idle_power4.S
> --- linux-2.6.17-rc1/arch/powerpc/kernel/idle_power4.S~no_idle_hz 2006-04-07 04:14:39.000000000 +0530
> +++ linux-2.6.17-rc1-root/arch/powerpc/kernel/idle_power4.S 2006-04-07 04:14:58.000000000 +0530
> @@ -30,6 +30,9 @@ END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP)
> cmpwi 0,r4,0
> beqlr
>
> + mflr r4
> + bl .stop_hz_timer
> + mtlr r4
This won't work - r4 is volatile across function calls, that is,
stop_hz_timer() could change r4 and is not required to save and
restore it.
Paul.
prev parent reply other threads:[~2006-04-07 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 6:31 [PATCH 2/4] tickless idle cpu: Skip ticks when CPU is idle Srivatsa Vaddagiri
2006-04-07 14:16 ` Kumar Gala
2006-04-10 12:23 ` Srivatsa Vaddagiri
2006-04-07 23:40 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17462.63610.217794.308786@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sri_vatsa_v@yahoo.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).