LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: David Wilder <dwilder@us.ibm.com>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, mchintage@in.ibm.com,
	fastboot@lists.osdl.org
Subject: Re: [PATCH] kdump-ppc64-xmon-stop-cpu
Date: Sat, 22 Apr 2006 18:43:34 +1000	[thread overview]
Message-ID: <17481.60598.162186.488312@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <443ADCF5.60702@us.ibm.com>

David Wilder writes:

> - During CPU(s) hang scenarios, kdump could not stop these CPUs. 
> However, the user could invoke soft-reset to shoot down CPUs reliably. 
> But, when the debugger is enabled, these CPUs are returned to hang state 
> after they exited from the debugger. This patch fixes this issue by 
> calling crash_kexec_secondary() before returns to previous state.

All three of your patches need a good 1-line description in the
subject and better description - one which is comprehensible to
someone who doesn't know all the internals of kdump, and with correct
English grammar.  I had to read this one about 4 times before I got
much of an idea what it was supposed to be about.  Please resubmit all
three patches in your series.

Paul.

      reply	other threads:[~2006-04-22  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-10 22:32 [PATCH] kdump-ppc64-xmon-stop-cpu David Wilder
2006-04-22  8:43 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17481.60598.162186.488312@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=dwilder@us.ibm.com \
    --cc=fastboot@lists.osdl.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mchintage@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox