From: Paul Mackerras <paulus@samba.org>
To: mel@csn.ul.ie (Mel Gorman)
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, vgoyal@in.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Compile failure fix for ppc on 2.6.17-rc4-mm3 (2nd attempt)
Date: Fri, 9 Jun 2006 19:36:56 +1000 [thread overview]
Message-ID: <17545.16696.195276.334774@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060529190515.GA17608@skynet.ie>
Mel Gorman writes:
> + res->end = -(-res->end & ~(unsigned long)mask); \
> + res->end += mask; \
I think this is equivalent to
res->end = (res->end + mask) | mask;
and I have to say the latter seems more understandable to me (and
doesn't need a cast) ...
Regards,
Paul.
next prev parent reply other threads:[~2006-06-09 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 15:12 [PATCH] Compile failure fix for ppc on 2.6.17-rc4-mm3 (2nd attempt) Mel Gorman
2006-05-26 16:49 ` Andrew Morton
2006-05-29 15:49 ` Mel Gorman
2006-05-29 16:22 ` Segher Boessenkool
2006-05-29 17:38 ` Mel Gorman
2006-05-29 17:56 ` Segher Boessenkool
2006-05-29 19:05 ` Mel Gorman
2006-06-09 9:36 ` Paul Mackerras [this message]
2006-06-13 16:49 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17545.16696.195276.334774@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).