From: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Daniel Walker (danielwa)" <danielwa@cisco.com>,
Will Deacon <will@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Rob Herring <robh@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pratyush Brahma <quic_pbrahma@quicinc.com>,
Tomas Mudrunka <tomas.mudrunka@gmail.com>,
Sean Anderson <sean.anderson@seco.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
Ruslan Ruslichenko <rruslich@cisco.com>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] CMDLINE: x86: convert to generic builtin command line
Date: Thu, 02 Oct 2025 15:38:12 -0700 [thread overview]
Message-ID: <1759444692.24579.8.camel@chimera> (raw)
In-Reply-To: <a2be781f-96b5-47d1-81fa-b20395ca293a@intel.com>
On Thu, 2025-10-02 at 14:55 -0700, Dave Hansen wrote:
> That's not a bad idea. Or, even if you can pick two amenable
> architectures to start with it will make it really obvious that this is
> useful. Two architectures means a *lot*, IMNHO. Two is a billion times
> better than one.
I think it's a bad idea, if I understand it correctly. The patchset
conceptually patches a mechanism of the kernel as a whole, but one which
just so happens to need to be implemented separately for each arch.
Breaking it down like you suggest creates an embarrassingly high
likelihood of different architectures' implementations of it going out
of sync, a previous situation that this patchset was partly intended to
address. I say keep it atomic. If it breaks on an arch or two but not
others and nobody notices right away, that would be better addressed
with a new patch when someone eventually does notice. Just my 2¢…
next prev parent reply other threads:[~2025-10-02 22:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 1:38 [PATCH 0/8] generic command line v6 Daniel Walker
2023-11-10 1:38 ` [PATCH 1/8] CMDLINE: add generic builtin command line Daniel Walker
2023-11-10 16:12 ` kernel test robot
2023-11-23 6:32 ` Christophe Leroy
2023-12-04 11:11 ` Jaskaran Singh
2023-11-10 1:38 ` [PATCH 2/8] scripts: insert-sys-cert: add command line insert capability Daniel Walker
2023-11-23 6:33 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 3/8] scripts: insert-sys-cert: change name to insert-symbol Daniel Walker
2023-11-23 6:34 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 4/8] CMDLINE: mips: convert to generic builtin command line Daniel Walker
2023-11-23 6:36 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 5/8] drivers: firmware: efi: libstub: enable generic commandline Daniel Walker
2023-11-10 4:23 ` kernel test robot
2023-11-23 6:37 ` Christophe Leroy
2023-12-12 9:55 ` Ard Biesheuvel
2023-12-12 17:25 ` Daniel Walker (danielwa)
2023-11-10 1:38 ` [PATCH 6/8] CMDLINE: x86: convert to generic builtin command line Daniel Walker
2023-11-10 7:17 ` kernel test robot
2025-10-02 20:49 ` Dave Hansen
2025-10-02 21:00 ` Daniel Walker (danielwa)
2025-10-02 21:10 ` Dave Hansen
2025-10-02 21:31 ` Daniel Walker (danielwa)
2025-10-02 21:55 ` Dave Hansen
2025-10-02 22:38 ` Daniel Gimpelevich [this message]
2025-10-02 23:10 ` Dave Hansen
2025-10-02 23:20 ` Daniel Gimpelevich
2025-10-02 23:39 ` Daniel Walker (danielwa)
2025-10-02 23:48 ` Dave Hansen
2023-11-10 1:38 ` [PATCH 7/8] of: replace command line handling Daniel Walker
2023-11-16 16:09 ` Rob Herring
2023-11-16 16:33 ` Daniel Walker (danielwa)
2023-11-23 6:39 ` Christophe Leroy
2023-11-10 1:38 ` [PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line Daniel Walker
2023-11-23 6:39 ` Christophe Leroy
2023-11-10 1:51 ` [PATCH 0/8] generic command line v6 Andrew Morton
2023-11-10 2:22 ` Daniel Walker (danielwa)
2023-11-10 2:40 ` Andrew Morton
2023-11-23 6:23 ` Christophe Leroy
-- strict thread matches above, loose matches on Subject: below --
2021-04-16 4:09 [PATCH 0/8] generic command line v4 Daniel Walker
2021-04-16 4:09 ` [PATCH 6/8] CMDLINE: x86: convert to generic builtin command line Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1759444692.24579.8.camel@chimera \
--to=daniel@gimpelevich.san-francisco.ca.us \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=danielwa@cisco.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=quic_pbrahma@quicinc.com \
--cc=robh@kernel.org \
--cc=rruslich@cisco.com \
--cc=ruslan.bilovol@gmail.com \
--cc=sean.anderson@seco.com \
--cc=tglx@linutronix.de \
--cc=tomas.mudrunka@gmail.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).