From: Paul Mackerras <paulus@samba.org>
To: Nicolas DET <nicolas@det-net.org>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] cputable: Correct IBM/750CXe rev3.x setup
Date: Tue, 8 Aug 2006 17:03:31 +1000 [thread overview]
Message-ID: <17624.14147.502469.136322@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060806104200.49c5f6bf.nicolas@det-net.org>
Nicolas DET writes:
> This patch simply add an entry in the cputable to recognize
> correctly the IBM750CXe rev3.1. Only rev 2.x was correctly detected
> before.
[Patch annoyingly as an attachment...]
+ { /* 750CXe rev 3.1 (0008x311) */
+ .pvr_mask = 0xffff0fff,
+ .pvr_value = 0x00080311,
+ .cpu_name = "750CXe",
Any reason to make this so specific? The rest of the entry is
identical to the ones we have for PVR values 0x0008221x and
0x00083214 (except that you missed out PPC_FEATURE_PPC_LE).
It looks to me like we could collapse all three into a single entry
with a suitable pvr_mask value (say 0xffff0e00?).
(akpm - consider this a nack)
Paul.
prev parent reply other threads:[~2006-08-08 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-06 8:42 [PATCH] cputable: Correct IBM/750CXe rev3.x setup Nicolas DET
2006-08-08 7:03 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17624.14147.502469.136322@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nicolas@det-net.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).