From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <error27@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Cc: Christophe Leroy <chleroy@kernel.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Roy Pledge <Roy.Pledge@nxp.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create()
Date: Wed, 29 Jul 2026 10:24:32 +0200 [thread overview]
Message-ID: <1764334d-7f3c-411e-be52-a3ccfd3a23b4@web.de> (raw)
In-Reply-To: <amdBqQfIsAjxMsqX@stanley.mountain>
…
>> +++ b/drivers/soc/fsl/dpio/dpio-service.c
…
>> - size = max_frames * sizeof(struct dpaa2_dq) + 64;
>> - ret->alloced_addr = kzalloc(size, GFP_KERNEL);
>> - if (!ret->alloced_addr) {
>> - kfree(ret);
>> + ret->alloced_addr = kzalloc(max_frames * sizeof(struct dpaa2_dq) + 64, GFP_KERNEL);
>> + if (!ret->alloced_addr)
>> return NULL;
>
> Why convert the ret allocation but not the ret->alloced_addr allocation?
I suggest to reconsider the suggested influence of the attribute “__free(kfree)”
once more also according to data structure members.
Regards,
Markus
next prev parent reply other threads:[~2026-07-29 8:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:02 [PATCH] soc: fsl: dpio: Use common error handling code in two functions Markus Elfring
2026-07-04 9:19 ` Christophe Leroy (CS GROUP)
2026-07-04 10:11 ` Markus Elfring
2026-07-06 10:36 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management " Markus Elfring
2026-07-06 10:38 ` [PATCH v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create() Markus Elfring
2026-07-27 11:31 ` Dan Carpenter
2026-07-29 8:24 ` Markus Elfring [this message]
2026-07-27 12:08 ` Ioana Ciornei
2026-07-27 12:24 ` [v2 " Markus Elfring
2026-07-27 12:46 ` Ioana Ciornei
2026-07-27 12:52 ` Markus Elfring
2026-07-28 6:55 ` Markus Elfring
2026-07-28 10:40 ` Ioana Ciornei
2026-07-28 11:15 ` Markus Elfring
2026-07-06 10:40 ` [PATCH v2 2/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_create() Markus Elfring
2026-07-27 11:32 ` Dan Carpenter
2026-07-27 12:14 ` [v2 " Markus Elfring
2026-07-27 12:09 ` [PATCH v2 " Ioana Ciornei
2026-07-27 13:14 ` [v2 " Markus Elfring
2026-07-27 9:57 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management in two functions Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1764334d-7f3c-411e-be52-a3ccfd3a23b4@web.de \
--to=markus.elfring@web.de \
--cc=Roy.Pledge@nxp.com \
--cc=chleroy@kernel.org \
--cc=error27@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox