From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: qiang.zhao@nxp.com, Chen Ni <nichen@iscas.ac.cn>
Cc: Christophe Leroy <chleroy@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: fsl: qe: qe_ports_ic: Consolidate chained IRQ handler install/remove
Date: Wed, 28 Jan 2026 12:01:31 +0100 [thread overview]
Message-ID: <176959784390.2069162.369898481051336357.b4-ty@kernel.org> (raw)
In-Reply-To: <20260119055715.889001-1-nichen@iscas.ac.cn>
On Mon, 19 Jan 2026 13:57:15 +0800, Chen Ni wrote:
> The driver currently sets the handler data and the chained handler in
> two separate steps. This creates a theoretical race window where an
> interrupt could fire after the handler is set but before the data is
> assigned, leading to a NULL pointer dereference.
>
> Replace the two calls with irq_set_chained_handler_and_data() to set
> both the handler and its data atomically under the irq_desc->lock.
>
> [...]
Applied, thanks!
[1/1] soc: fsl: qe: qe_ports_ic: Consolidate chained IRQ handler install/remove
Best regards,
--
Christophe Leroy (CS GROUP) <chleroy@kernel.org>
prev parent reply other threads:[~2026-01-28 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 5:57 [PATCH] soc: fsl: qe: qe_ports_ic: Consolidate chained IRQ handler install/remove Chen Ni
2026-01-19 7:00 ` Christophe Leroy (CS GROUP)
2026-01-28 11:01 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176959784390.2069162.369898481051336357.b4-ty@kernel.org \
--to=chleroy@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nichen@iscas.ac.cn \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox