From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4274FEF36E7 for ; Mon, 9 Mar 2026 06:49:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fTng93YXjz309P; Mon, 09 Mar 2026 17:49:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773038965; cv=none; b=ZlpaL48fdZ907GZVeXBT/b4jwVaguNhyI33qZ/Y/zLDvwg3FYJ6fI99W6lyPwEVFdMhmbP8I78T8p8XS8qfTev2AaytZ7LfRI+2ijC5mSUgIAyfF0TV6hOCrrClMSNl9LRmi5ypAdrGXIB56hGT4qZzO12Qr3IunqFtYEu9u9FXFDnOUw65ltnpa3mgHcudhAtcoakYr2XbcsTBGxB1r5/iMgyzw1NgtT/FOshyW/a/Wii+r/pljUkLfcMWXhXiRVUpreBqoUMGjB4djDASxir7Cc4noa1JDhnwo7jI6/V5TicaMae4CItTdu2WMcKMNQ/2pqwetSWxSY1Wk8jyhtw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773038965; c=relaxed/relaxed; bh=9rea/vjeMUUW3SPeWNeQvX4Qfy/WVzcqQb0NrtwQ8Ck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XdJrusXYE9Qe3trCXUFnLvciMxm+Dv9X0XL4XqcqOpi6jfnbz2noWExrTCCdu2UFw15+EGFG8NRSTq0f7xd65/WRpRYg+cmIZT6bQYNzEY4UqwDvRhhkrqZ0rEi1AFAGanDdi2NTDXSQgdwVFhdOLHkIBnDgY2kvMtMPAB2XJgflY95bqud9C3PQEZ++Fx16M3zEQIuf5F+utzscalYMp9WhnTbUT4oOktfVNWdJ3mpPQ413D+F1rLXU252ShAc1j2/K4PG8IgdV2P41i1gqdn0YxXta1Gg9KsxnheM/ForpZLp6zg8MadwLI+QOn+etiXNGNdQ0BpG7MP54A3xwxQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SAHCok30; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nsc@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SAHCok30; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=nsc@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fTng81HnPz2xlh for ; Mon, 09 Mar 2026 17:49:24 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 11FFB4411F; Mon, 9 Mar 2026 06:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A789C4CEF7; Mon, 9 Mar 2026 06:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773038961; bh=mBGAy+m59z4WIEXrNU6lVwn2ubiB5FyyhHyt/vKyIwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SAHCok30el3I22tEqGLE1AsTFRcIxNAv18AGEYQTYGnuLynlmwQV37mqVXirUlEej z4I4v2lMrfd9uGw2WKlMubgUAX/oKqjPAYO0K5hKm6yXr25Y5FotuZ0D/r+YEkSdAM 0EZY59yCS3qEnIhTmaI5ofWEtmyWNmIa2iEt45YWJ2h7IDT4in6/Z2FsGx8l0OqNn+ gCQVwJ8jSVG5Qv5KjuL62+1sfKbp1nVDoJRB0C79e9WFAazt8pc1FLS/lNZQSYuPVI X+0LuwPPOLpnusHuaR0u/h3HuW/1BocPwfNrtCLot/ti//rWfPsZdw4Rp1z4IzG5jQ 8a5GB68SEb+ag== From: Nicolas Schier To: Nathan Chancellor Cc: Nicolas Schier , Linus Torvalds , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ard Biesheuvel , Ilias Apalodimas , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 0/2] kbuild: Switch from '-fms-extensions' to '-fms-anonymous-structs' when available Date: Mon, 9 Mar 2026 07:49:13 +0100 Message-ID: <177303890212.240716.12941791284325631253.b4-ty@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223-fms-anonymous-structs-v1-0-8ee406d3c36c@kernel.org> References: <20260223-fms-anonymous-structs-v1-0-8ee406d3c36c@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 23 Feb 2026 12:10:27 -0700, Nathan Chancellor wrote: > The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild: > enable -fms-extensions") in 6.19 to gain access to a Microsoft > (originally Plan 9) extension around including a tagged structure/union > anonymously in an other structure/union. Since then, Clang 23.0.0 > (current main) has added a flag to enable only that extension, rather > than all Microsoft extensions, '-fms-anonymous-structs' [1]. Using this > narrower compiler option would have avoided the build error fixed by > commit a6773e6932cb ("jfs: Rename _inline to avoid conflict with clang's > '-fms-extensions'"). While these errors are not expected to be common, > using the narrower option when available has no drawbacks because the > kernel only cares about this extension in '-fms-extensions', no others. > While this could result in build errors for folks using > '-fms-anonymous-structs' if a developer uses another extension in > '-fms-extensions' (either intentionally or unintentionally), flagging > these uses for further scrutiny seems worthwhile. > > [...] Applied to kbuild/linux.git (kbuild-next-unstable), thanks! [1/2] kbuild: Consolidate C dialect options https://git.kernel.org/kbuild/c/f3fead1c [2/2] kbuild: Use '-fms-anonymous-structs' if it is available https://git.kernel.org/kbuild/c/c14d8386 Acks and review trailers are still welcome! Please look out for regression or issue reports or other follow up comments, as they may result in the patch/series getting dropped, reverted or modified (e.g. trailers). Patches applied to the kbuild-next-unstable branch are accepted pending wider testing in linux-next and any post-commit review; they will generally be moved to the kbuild-next branch in about a week if no issues are found. Best regards, -- Nicolas