* [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes
@ 2025-10-29 17:40 Rob Herring (Arm)
2025-11-24 18:31 ` Rob Herring
2026-03-11 2:14 ` Madhavan Srinivasan
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-10-29 17:40 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy
Cc: Stan Johnson, linuxppc-dev, linux-kernel
Similar to other PowerMac mac-io devices, the media-bay node is missing the
"#size-cells" property.
Depends-on: commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
Reported-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
arch/powerpc/kernel/prom_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 827c958677f8..f26e80cbc615 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2893,7 +2893,8 @@ static void __init fixup_device_tree_pmac(void)
for (node = 0; prom_next_node(&node); ) {
type[0] = '\0';
prom_getprop(node, "device_type", type, sizeof(type));
- if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
+ if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s") &&
+ prom_strcmp(type, "media-bay"))
continue;
if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes
2025-10-29 17:40 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes Rob Herring (Arm)
@ 2025-11-24 18:31 ` Rob Herring
2026-03-11 2:14 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2025-11-24 18:31 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy
Cc: Stan Johnson, linuxppc-dev, linux-kernel
On Wed, Oct 29, 2025 at 12:41 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> Similar to other PowerMac mac-io devices, the media-bay node is missing the
> "#size-cells" property.
>
> Depends-on: commit 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
> Reported-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> arch/powerpc/kernel/prom_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Ping!
>
> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> index 827c958677f8..f26e80cbc615 100644
> --- a/arch/powerpc/kernel/prom_init.c
> +++ b/arch/powerpc/kernel/prom_init.c
> @@ -2893,7 +2893,8 @@ static void __init fixup_device_tree_pmac(void)
> for (node = 0; prom_next_node(&node); ) {
> type[0] = '\0';
> prom_getprop(node, "device_type", type, sizeof(type));
> - if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
> + if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s") &&
> + prom_strcmp(type, "media-bay"))
> continue;
>
> if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes
2025-10-29 17:40 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes Rob Herring (Arm)
2025-11-24 18:31 ` Rob Herring
@ 2026-03-11 2:14 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2026-03-11 2:14 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy,
Rob Herring (Arm)
Cc: Stan Johnson, linuxppc-dev, linux-kernel
On Wed, 29 Oct 2025 12:40:46 -0500, Rob Herring (Arm) wrote:
> Similar to other PowerMac mac-io devices, the media-bay node is missing the
> "#size-cells" property.
>
>
Applied to powerpc/fixes.
[1/1] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes
https://git.kernel.org/powerpc/c/6fc5d63c6ff5fe5e5beea3e7fe2ca3058351ae99
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-11 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 17:40 [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerMac media-bay nodes Rob Herring (Arm)
2025-11-24 18:31 ` Rob Herring
2026-03-11 2:14 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox