From: Paul Mackerras <paulus@samba.org>
To: Li Yang <leoli@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] qe_lib: Remove immrbar_virt_to_phys() function
Date: Mon, 30 Oct 2006 14:21:42 +1100 [thread overview]
Message-ID: <17733.28614.62353.822225@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <453F44E6.8030706@freescale.com>
Li Yang writes:
> Remove private physical address mapping routine in qe_lib. Users
> of qe_lib should use generic functions like iopa().
> The change also addresses a bug found by Timur Tabi that cmd_input
> got mapped in qe_issue_cmd(). It should be written to CECDR
> unmodified.
Do you mean that the argument to qe_issue_cmd is a physical address?
It seems to me that the bug fix you mention is the main thing the
patch does, and the removal of immrvar_virt_to_phys is a cleanup on
the side that is made possible by the bugfix.
Paul.
next prev parent reply other threads:[~2006-10-30 3:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 11:05 [PATCH] qe_lib: Remove immrbar_virt_to_phys() function Li Yang
2006-10-30 3:21 ` Paul Mackerras [this message]
2006-10-30 6:22 ` Li Yang-r58472
2006-10-30 22:15 ` Kumar Gala
2006-10-31 2:28 ` Li Yang-r58472
2006-10-31 2:46 ` Kumar Gala
2006-10-31 2:56 ` Li Yang-r58472
2006-10-31 5:05 ` Kumar Gala
2006-10-31 5:25 ` Li Yang-r58472
2006-10-31 5:30 ` Kumar Gala
2006-10-31 5:34 ` Li Yang-r58472
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17733.28614.62353.822225@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).