From: Arnd Bergmann <arnd@arndb.de>
To: Alistair Popple <alistair@popple.id.au>
Cc: devicetree@vger.kernel.org, cjb@laptop.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver
Date: Fri, 21 Feb 2014 15:14:30 +0100 [thread overview]
Message-ID: <1773685.WfxOP0FuHM@wuerfel> (raw)
In-Reply-To: <1392964293-13687-2-git-send-email-alistair@popple.id.au>
On Friday 21 February 2014 17:31:27 Alistair Popple wrote:
>
> +config MMC_SDHCI_OF_476GTR
> + tristate "SDHCI OF support for the IBM PPC476GTR SoC"
> + depends on MMC_SDHCI_PLTFM
> + depends on PPC_OF
> + help
> + This selects the Secure Digital Host Controller Interface (SDHCI)
> + found on the PPC476GTR SoC.
> +
> + If you have a controller with this interface, say Y or M here.
> +
> + If unsure, say N.
Your driver doesn't actually do anything beyond what is in the common
sdhci-pltfm.c infrastructure. IMHO you really shoulnd't need a SoC
specific abstraction for it at all and instead add a generic
platform driver registration into sdhci-pltfm.c. I'd suggest
you use "generic-sdhci" (similar to what we do for usb-ohci and usb-ehci
now) as the compatible string and change your device tree to claim
compatibility with that and your soc-specific string.
Arnd
next prev parent reply other threads:[~2014-02-21 14:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 6:31 [PATCH 0/7] IBM Akebono/PPC476GTR Support Alistair Popple
2014-02-21 6:31 ` [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver Alistair Popple
2014-02-21 14:14 ` Arnd Bergmann [this message]
2014-02-24 0:38 ` Alistair Popple
2014-02-21 6:31 ` [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-02-21 11:18 ` Mark Rutland
2014-02-24 2:09 ` Alistair Popple
2014-02-21 6:31 ` [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR Alistair Popple
2014-02-21 14:16 ` Arnd Bergmann
2014-02-24 0:20 ` Alistair Popple
2014-02-21 15:34 ` Alan Stern
2014-02-21 6:31 ` [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver Alistair Popple
2014-02-21 11:48 ` Mark Rutland
2014-02-21 14:21 ` Arnd Bergmann
2014-02-22 2:32 ` Tony Prisk
2014-02-21 15:41 ` Alan Stern
2014-02-24 0:28 ` Alistair Popple
2014-02-21 6:31 ` [PATCH 5/7] IBM Currituck: Clean up board specific code before adding Akebono code Alistair Popple
2014-02-21 6:31 ` [PATCH 6/7] IBM Akebono: Add the Akebono platform Alistair Popple
2014-02-21 6:31 ` [PATCH 7/7] powerpc: Added PCI MSI support using the HSTA module Alistair Popple
2014-02-21 14:33 ` Arnd Bergmann
2014-02-21 20:41 ` Benjamin Herrenschmidt
2014-02-21 21:53 ` Arnd Bergmann
2014-02-25 5:54 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1773685.WfxOP0FuHM@wuerfel \
--to=arnd@arndb.de \
--cc=alistair@popple.id.au \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).