From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 653702C0322 for ; Sat, 22 Feb 2014 01:20:33 +1100 (EST) From: Arnd Bergmann To: Alistair Popple Subject: Re: [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver Date: Fri, 21 Feb 2014 15:14:30 +0100 Message-ID: <1773685.WfxOP0FuHM@wuerfel> In-Reply-To: <1392964293-13687-2-git-send-email-alistair@popple.id.au> References: <1392964293-13687-1-git-send-email-alistair@popple.id.au> <1392964293-13687-2-git-send-email-alistair@popple.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: devicetree@vger.kernel.org, cjb@laptop.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 21 February 2014 17:31:27 Alistair Popple wrote: > > +config MMC_SDHCI_OF_476GTR > + tristate "SDHCI OF support for the IBM PPC476GTR SoC" > + depends on MMC_SDHCI_PLTFM > + depends on PPC_OF > + help > + This selects the Secure Digital Host Controller Interface (SDHCI) > + found on the PPC476GTR SoC. > + > + If you have a controller with this interface, say Y or M here. > + > + If unsure, say N. Your driver doesn't actually do anything beyond what is in the common sdhci-pltfm.c infrastructure. IMHO you really shoulnd't need a SoC specific abstraction for it at all and instead add a generic platform driver registration into sdhci-pltfm.c. I'd suggest you use "generic-sdhci" (similar to what we do for usb-ohci and usb-ehci now) as the compatible string and change your device tree to claim compatibility with that and your soc-specific string. Arnd