From: Paul Mackerras <paulus@samba.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] setup_kcore(): Fix incorrect function name in panic() call.
Date: Tue, 21 Nov 2006 09:27:59 +1100 [thread overview]
Message-ID: <17762.11247.302674.175475@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0611170620240.16998@pademelon.sonytel.be>
Geert Uytterhoeven writes:
> On Fri, 17 Nov 2006, Geert Uytterhoeven wrote:
> > On Fri, 17 Nov 2006, Jeremy Kerr wrote:
> > >
> > > > - panic("mem_init: kmalloc failed\n");
> > > > + panic("setup_kcore: kmalloc failed\n");
> > >
> > > How about:
> > >
> > > panic("%s: kmalloc_failed\n", __FUNCTION__);
> > >
> > > To prevent this happening again?
> >
> > You're right, thanks for the suggestion!
>
> Updated patch below:
Grumble.
Please don't send patches that you want to go upstream with a subject
starting with "Re:" and a whole pile of stuff preceding the patch
description. Do it like Andrew Morton describes in:
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Regards,
Paul.
prev parent reply other threads:[~2006-11-20 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 3:47 [PATCH] setup_kcore(): Fix incorrect function name in panic() call Geert Uytterhoeven
2006-11-17 3:58 ` Jeremy Kerr
2006-11-17 4:11 ` Geert Uytterhoeven
2006-11-17 5:21 ` Geert Uytterhoeven
2006-11-20 22:27 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17762.11247.302674.175475@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).