public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
From: Sascha Bischoff <Sascha.Bischoff@arm.com>
To: "maz@kernel.org" <maz@kernel.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"ioana.ciornei@nxp.com" <ioana.ciornei@nxp.com>,
	"chleroy@kernel.org" <chleroy@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH 0/6] fsl-mc: Move fsl_over to device MSI
Date: Thu, 19 Feb 2026 13:56:44 +0000	[thread overview]
Message-ID: <1782efb97a597e750069334bbeddc03b35fca862.camel@arm.com> (raw)
In-Reply-To: <20260218135203.2267907-1-maz@kernel.org>

On Wed, 2026-02-18 at 13:51 +0000, Marc Zyngier wrote:
> Over the past few years, I have become increasingly annoyed by this
> sort of messages in my boot log:
> 
> [    0.067861] fsl-mc MSI: ITS@0x100100040000 domain created
> [    0.073352] fsl-mc MSI: ITS@0x100100060000 domain created
> [    0.078841] fsl-mc MSI: ITS@0x100100080000 domain created
> [    0.084328] fsl-mc MSI: ITS@0x1001000a0000 domain created
> [    0.089815] fsl-mc MSI: ITS@0x1001000c0000 domain created
> [    0.095303] fsl-mc MSI: ITS@0x1001000e0000 domain created
> [    0.100792] fsl-mc MSI: ITS@0x100100100000 domain created
> [    0.106281] fsl-mc MSI: ITS@0x100100120000 domain created
> 
> While this is useful on fsl-mc systems, this is completely irrelevant
> on 99.99999% of the arm64 machines, which know nothing about the
> Freescale stuff. Including all of my machine -- bar *one*.
> 
> Global MSI domains such as the above have been obsoleted for the past
> two years, but nobody at NXP seems to have got the message.
> 
> The obvious solution is to delete some code! While my first port of
> call would be to just 'git rm -r drivers/bus/fsl-mc' (only kidding!),
> a less invasive solution is to drag that code into the present times.
> Which is what this series is doing by converting the whole thing to
> device MSI, reusing the platform MSI infrastructure instead of
> duplicating it.
> 
> This results in the expected cleanup, and kills the last user of the
> non-device-MSI stuff on arm64. You're welcome.
> 
> Marc Zyngier (6):
>   fsl-mc: Remove MSI domain propagation to sub-devices
>   fsl_mc: Add minimal infrastructure to use platform MSI
>   irqchip/gic-v3-its: Add fsl_mc device plumbing to the msi-parent
>     handling
>   fsl_mc: Switch over to per-device platform MSI
>   fsl_mc: Remove legacy MSI implementation
>   platform-msi: Remove stale comment
> 
>  drivers/base/platform-msi.c                 |   4 -
>  drivers/bus/fsl-mc/dprc-driver.c            |  14 +-
>  drivers/bus/fsl-mc/fsl-mc-bus.c             |   4 +-
>  drivers/bus/fsl-mc/fsl-mc-msi.c             | 142 +++--------------
>  drivers/bus/fsl-mc/fsl-mc-private.h         |   2 +-
>  drivers/irqchip/Kconfig                     |   6 -
>  drivers/irqchip/Makefile                    |   1 -
>  drivers/irqchip/irq-gic-its-msi-parent.c    |   7 +-
>  drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 168 ------------------
> --
>  include/linux/fsl/mc.h                      |   6 +-
>  10 files changed, 33 insertions(+), 321 deletions(-)
>  delete mode 100644 drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c
> 

I have tested this series (applied to 6.19) with a SolidRun ClearFog CX
LX2 (LX2160A-based), and can confirm that the MSIs are working as I'd
expect them to. Therefore:

Tested-by: Sascha Bischoff <sascha.bischoff@arm.com>

Thanks,
Sascha

  parent reply	other threads:[~2026-02-19 21:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 13:51 [PATCH 0/6] fsl-mc: Move fsl_over to device MSI Marc Zyngier
2026-02-18 13:51 ` [PATCH 1/6] fsl-mc: Remove MSI domain propagation to sub-devices Marc Zyngier
2026-02-18 13:51 ` [PATCH 2/6] fsl_mc: Add minimal infrastructure to use platform MSI Marc Zyngier
2026-02-18 13:52 ` [PATCH 3/6] irqchip/gic-v3-its: Add fsl_mc device plumbing to the msi-parent handling Marc Zyngier
2026-02-22 22:57   ` Thomas Gleixner
2026-02-23  9:01     ` Marc Zyngier
2026-02-23 13:02       ` Thomas Gleixner
2026-02-23 13:22         ` Marc Zyngier
2026-02-24  6:52           ` Thomas Gleixner
2026-02-18 13:52 ` [PATCH 4/6] fsl_mc: Switch over to per-device platform MSI Marc Zyngier
2026-02-18 13:52 ` [PATCH 5/6] fsl_mc: Remove legacy MSI implementation Marc Zyngier
2026-02-18 13:52 ` [PATCH 6/6] platform-msi: Remove stale comment Marc Zyngier
2026-02-19 13:56 ` Sascha Bischoff [this message]
2026-02-20 15:41 ` [PATCH 0/6] fsl-mc: Move fsl_over to device MSI Ioana Ciornei
2026-02-23 13:37   ` Marc Zyngier
2026-02-23 13:54     ` Christophe Leroy (CS GROUP)
2026-02-24  6:54       ` Thomas Gleixner
2026-02-24 10:19       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1782efb97a597e750069334bbeddc03b35fca862.camel@arm.com \
    --to=sascha.bischoff@arm.com \
    --cc=chleroy@kernel.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maz@kernel.org \
    --cc=nd@arm.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox