From: Paul Mackerras <paulus@samba.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linuxppc-dev Development <linuxppc-dev@ozlabs.org>,
Sylvain Munaut <tnt@246tNt.com>
Subject: Re: [PATCH] add restart function for mpc52xx
Date: Fri, 12 Jan 2007 14:37:23 +1100 [thread overview]
Message-ID: <17831.627.162751.166002@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070111152137.GG11226@localhost.localdomain>
Sascha Hauer writes:
> > This suffers from the same bug mpc83xx_restart has. We can NOT do an
> > ioremap inside the restart function. We may get called from
> > interrupt context on a panic and will not be able to do the ioremap
> > (). The simplest thing is to do the mapping earlier in an init call
> > and save the pointer, its not perfect, but better.
> >
>
> I'm beginning to hate this whole pseudo OF thing for embedded systems.
Not being able to ioremap at interrupt time has absolutely _nothing_
to do with the device tree.
> All we need to know is that we have a mpc52xx processor.
... until we get a system with a mpc52xx and some extra stuff. Then
you say "OK, we just need a boardinfo_t" and then we get 57 different
variants of boardinfo_t and then we're back in the mess that arch/ppc
got into.
Paul.
next prev parent reply other threads:[~2007-01-12 3:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 12:28 [PATCH] add restart function for mpc52xx Sascha Hauer
2007-01-11 13:15 ` Sylvain Munaut
2007-01-11 13:59 ` Kumar Gala
2007-01-11 15:21 ` Sascha Hauer
2007-01-11 15:50 ` Grant Likely
2007-01-11 16:20 ` Grant Likely
2007-01-11 16:57 ` Segher Boessenkool
2007-01-12 3:37 ` Paul Mackerras [this message]
2007-01-12 8:46 ` Sascha Hauer
2007-01-12 9:00 ` Sylvain Munaut
2007-01-12 10:42 ` Sascha Hauer
2007-01-12 10:43 ` Sylvain Munaut
2007-01-12 16:05 ` Kumar Gala
2007-01-12 12:27 ` Segher Boessenkool
2007-01-28 18:09 ` Robert Schwebel
2007-01-28 21:48 ` Benjamin Herrenschmidt
2007-01-28 23:56 ` David Gibson
2007-01-12 12:23 ` Segher Boessenkool
2007-01-12 12:39 ` Sylvain Munaut
2007-01-12 12:19 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17831.627.162751.166002@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=s.hauer@pengutronix.de \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).