linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 01/18] Include autoconf.h from the bootwrapper.
Date: Fri, 26 Jan 2007 09:15:10 +1100	[thread overview]
Message-ID: <17849.11246.51329.645604@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20070125173915.GA18889@ld0162-tx32.am.freescale.net>

Scott Wood writes:

> So basically, there'd be several lines in the arch/powerpc/boot/Makefile
> like this?
> 
> cflags-$(CONFIG_6xx) += -DCONFIG_6xx
> cflags-$(CONFIG_8xx) += -DCONFIG_8xx
> cflags-$(CONFIG_E500) += -DCONFIG_E500
> BOOTCFLAGS += $(cflags-y)

No no no.  I said the Makefile could pass different flags to wrapper
depending on the config, that is, to the *invocation* of wrapper, not
the building of wrapper.  As it does already - if you have
CONFIG_PPC_PMAC, it runs wrapper with "-p pmac"; if you have
CONFIG_PPC_PSERIES, it runs wrapper with "-p pseries".  In your case
you would be using "-p myboard_uboot_bd_t_variant_59" or something
(hopefully more concise than that, of course :).

> I don't really see the point (a simple grep will show you all the config
> dependencies in the bootwrapper, to verify that it's only platform stuff
> and not actual options), but I can do it that way if you really want. 
> One way or another, the information has to be there, and it has to be
> compile-time or else the bd_info struct layout will be wrong.

So you will end up with a bunch of .o files, one for each possible
bd_t variant.  They will all get built and the appropriate one will
get selected by wrapper based on the value you give with the -p
option.  The line in arch/powerpc/boot/Makefile that defines src-plat
will list all of them.

Paul.

      reply	other threads:[~2007-01-25 22:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24 21:06 [PATCH 01/18] Include autoconf.h from the bootwrapper Scott Wood
2007-01-24 23:51 ` David Gibson
2007-01-25  2:08   ` Kumar Gala
2007-01-25  2:21     ` David Gibson
2007-01-25  2:40     ` Paul Mackerras
2007-01-25 17:39       ` Scott Wood
2007-01-25 22:15         ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17849.11246.51329.645604@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).