From: Paul Mackerras <paulus@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Revised: [PATCH 5/11] Celleb: htab routines
Date: Thu, 8 Feb 2007 15:09:06 +1100 [thread overview]
Message-ID: <17866.41570.85932.301461@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1170880786.2620.285.camel@localhost.localdomain>
Benjamin Herrenschmidt writes:
> On Wed, 2007-02-07 at 17:45 +0900, Ishizaki Kou wrote:
>
> > + local_irq_save(flags);
> > + spin_lock(&beat_htab_lock);
> > + dummy1 = beat_lpar_hpte_getword0(slot);
> > +
>
> Sorry if I was not very clear... In that specific case, you can use
> spin_lock_irqsave(). The above works though, thus the patch can be
> merged, and we can do a cleanup patch on top later on to "fix it up"
I already merged the version of the patch that uses spin_lock_irqsave
and spin_unlock_irqrestore. Please send a further patch on top of
that if anything needs to be changed.
Paul.
prev parent reply other threads:[~2007-02-08 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 8:45 Revised: [PATCH 5/11] Celleb: htab routines Ishizaki Kou
2007-02-07 20:39 ` Benjamin Herrenschmidt
2007-02-08 4:09 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17866.41570.85932.301461@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).