From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Message-ID: <17921.3150.242081.66071@cargo.ozlabs.ibm.com> Date: Wed, 21 Mar 2007 21:43:26 +1100 From: Paul Mackerras To: Yuri Tikhonov Subject: Re: [PATCH] ppc: Add support for bigger page sizes than 4KB on PPC44x In-Reply-To: <200703171441.51276.yur@emcraft.com> References: <200703161634.58444.yur@emcraft.com> <17915.7048.393811.714143@cargo.ozlabs.ibm.com> <200703171441.51276.yur@emcraft.com> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Yuri Tikhonov writes: > Do you think that replacing one integer option CONFIG_PPC_PAGE_SHIFT with > three logical options (i.e., CONFIG_PPC_PAGE_SIZE_4K, > CONFIG_PPC_PAGE_SIZE_16K and CONFIG_PPC_PAGE_SIZE_64K) will be the better > choice ? I think you should use a choice...endchoice construct in Kconfig, which will result in 2 config options, or 3 if you choose to support 16k pages. Paul.