[PATCH 2.6.22] [resend] Allow PMU LED control on PowerMac 7, 2 and 7, 3

[PATCH 2.6.22] [resend] Allow PMU LED control on PowerMac 7, 2 and 7, 3

[Tony Vroon]

The previous patch was not the correct file and would not have compiled. Apologies.

This allows the PMU LED on both a PowerMac 7,2 (Dual G5 2.0GHz, June 2003) 
and a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) to be controlled.
The physical LED is never off, unlike an iBook/PowerBook LED.
It is rather dim ("off") or very bright ("on").
A patch to add a LED trigger to the libata core has been sent to Jeff Garzik.

Signed-off-by: Tony Vroon <chainsaw@gentoo.org>

--- linux-2.6/drivers/macintosh/via-pmu-led.c.orig	2007-03-09 22:38:31.000000000 +0000
+++ linux-2.6/drivers/macintosh/via-pmu-led.c	2007-03-18 19:46:27.000000000 +0000
@@ -124,7 +124,9 @@
 	if (model == NULL)
 		return -ENODEV;
 	if (strncmp(model, "PowerBook", strlen("PowerBook")) != 0 &&
-	    strncmp(model, "iBook", strlen("iBook")) != 0) {
+	    strncmp(model, "iBook", strlen("iBook")) != 0 &&
+	    strncmp(model, "PowerMac7,2", strlen("PowerMac7,2")) != 0 &&
+	    strncmp(model, "PowerMac7,3", strlen("PowerMac7,3")) != 0) {
 		of_node_put(dt);
 		/* ignore */
 		return -ENODEV;

Re: [PATCH 2.6.22] [resend] Allow PMU LED control on PowerMac 7, 2 and 7, 3

[Paul Mackerras]

Tony Vroon writes:

>  	if (strncmp(model, "PowerBook", strlen("PowerBook")) != 0 &&
> -	    strncmp(model, "iBook", strlen("iBook")) != 0) {
> +	    strncmp(model, "iBook", strlen("iBook")) != 0 &&
> +	    strncmp(model, "PowerMac7,2", strlen("PowerMac7,2")) != 0 &&
> +	    strncmp(model, "PowerMac7,3", strlen("PowerMac7,3")) != 0) {

Since we only want to accept "PowerMac7,2" or "PowerMac7,3", and not
any longer strings ("PowerMac7,30" for instance), I think the
comparisons you have added should use strcmp rather than strncmp.

Paul.

Re: [PATCH 2.6.22] [resend] Allow PMU LED control on PowerMac 7, 2 and 7, 3

[William Pitcock]

Hello,

This patch also works on PowerMac3,5. It is also confirmed to work on the 
iMac "Flower Power" model, but I do not have the specific model ID for 
that on me at the moment.

William

On Sun, 18 Mar 2007, Tony Vroon wrote:

> The previous patch was not the correct file and would not have compiled. Apologies.
>
> This allows the PMU LED on both a PowerMac 7,2 (Dual G5 2.0GHz, June 2003)
> and a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) to be controlled.
> The physical LED is never off, unlike an iBook/PowerBook LED.
> It is rather dim ("off") or very bright ("on").
> A patch to add a LED trigger to the libata core has been sent to Jeff Garzik.
>
> Signed-off-by: Tony Vroon <chainsaw@gentoo.org>
>
> --- linux-2.6/drivers/macintosh/via-pmu-led.c.orig	2007-03-09 22:38:31.000000000 +0000
> +++ linux-2.6/drivers/macintosh/via-pmu-led.c	2007-03-18 19:46:27.000000000 +0000
> @@ -124,7 +124,9 @@
> 	if (model == NULL)
> 		return -ENODEV;
> 	if (strncmp(model, "PowerBook", strlen("PowerBook")) != 0 &&
> -	    strncmp(model, "iBook", strlen("iBook")) != 0) {
> +	    strncmp(model, "iBook", strlen("iBook")) != 0 &&
> +	    strncmp(model, "PowerMac7,2", strlen("PowerMac7,2")) != 0 &&
> +	    strncmp(model, "PowerMac7,3", strlen("PowerMac7,3")) != 0) {
> 		of_node_put(dt);
> 		/* ignore */
> 		return -ENODEV;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

Re: [PATCH 2.6.22] [resend] Allow PMU LED control on PowerMac 7, 2 and 7, 3

[Segher Boessenkool]

> This patch also works on PowerMac3,5. It is also confirmed to work on 
> the
> iMac "Flower Power" model, but I do not have the specific model ID for
> that on me at the moment.

PowerMac4,1 (all of the latest iMac G3s have this ID, not
just the "Flower Power").


Segher