From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: sachinp@linux.vnet.ibm.com,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module
Date: Thu, 19 Mar 2020 11:56:11 -0400 [thread overview]
Message-ID: <17b5d98c-76b2-63c0-798a-920d91fec618@linux.ibm.com> (raw)
In-Reply-To: <20200319142714.GB3703@linux.intel.com>
On 3/19/20 10:27 AM, Jarkko Sakkinen wrote:
> On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote:
>> On 3/18/20 3:42 PM, Jarkko Sakkinen wrote:
>>> On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:
>>>> From: Stefan Berger <stefanb@linux.ibm.com>
>>>>
>>>> This patch fixes the following problem when the ibmvtpm driver
>>>> is built as a module:
>>>>
>>>> ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
>>>> make: *** [Makefile:1298: modules] Error 2
>>>>
>>>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>>> Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
>>> Thanks.
>> I did not add the fixes tag because I do not know the final commit hash, or
>> is it the final commit hash once it is in linux-next? I doubt it with all
>> the merging that can occur.
> Can you send me a new version after rc1 is out?
Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once
the bad patch is in linux-next. So I reposted yesterday (with a stray
'q' in the title :-( ):
https://lkml.org/lkml/2020/3/18/1283
Stefan
>
> /Jarkko
next prev parent reply other threads:[~2020-03-19 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 13:08 [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module Stefan Berger
2020-03-17 15:22 ` Sachin Sant
2020-03-17 15:30 ` Stefan Berger
2020-03-18 19:42 ` Jarkko Sakkinen
2020-03-18 19:53 ` Stefan Berger
2020-03-19 14:27 ` Jarkko Sakkinen
2020-03-19 15:56 ` Stefan Berger [this message]
2020-03-19 21:16 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b5d98c-76b2-63c0-798a-920d91fec618@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).