From: Paul Mackerras <paulus@samba.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make powerpc BUG_ON() OK with pointers and bitwise
Date: Fri, 27 Jul 2007 09:30:38 +1000 [thread overview]
Message-ID: <18089.11934.607569.349144@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <E1IE6JZ-0005QA-R8@ZenIV.linux.org.uk>
Al Viro writes:
> Since powerpc insists on printing the _value_ of condition
We don't _print_ the value of the condition, we give it to a
conditional-trap instruction which will trap if it is non-zero.
> and on casting it to long... At least let's make it a force-cast.
The long cast is to make sure it's sign-extended to the full register
width. Adding __force looks fine.
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Paul Mackerras <paulus@samba.org>
prev parent reply other threads:[~2007-07-26 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 16:35 [PATCH] make powerpc BUG_ON() OK with pointers and bitwise Al Viro
2007-07-26 23:30 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18089.11934.607569.349144@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).