From: Paul Mackerras <paulus@samba.org>
To: Emil Medve <Emilian.Medve@Freescale.com>
Cc: linuxppc-dev@ozlabs.org, kumar.gala@Freescale.com,
bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] Fix build errors when BLOCK=n
Date: Wed, 19 Sep 2007 14:49:11 +1000 [thread overview]
Message-ID: <18160.43591.441863.931220@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <11900663131073-git-send-email-Emilian.Medve@Freescale.com>
Emil Medve writes:
> The fix tries to use the smallest scope CONFIG_* symbols that will fix the build
> problem. In this case <linux/ide.h> needs to be included only if IDE=y or
> IDE=m were selected. Also, ppc_ide_md is needed only if BLK_DEV_IDE=y or
> BLK_DEV_IDE=m
It would be nicer to remove the ppc_ide_md stuff from ppc_ksyms.c
altogether and just put the EXPORT_SYMBOL in setup_32.c.
Paul.
prev parent reply other threads:[~2007-09-19 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 21:58 [PATCH] [POWERPC] Fix build errors when BLOCK=n Emil Medve
2007-09-17 22:34 ` David Howells
2007-09-17 22:43 ` Medve Emilian-EMMEDVE1
2007-09-19 4:49 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18160.43591.441863.931220@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Emilian.Medve@Freescale.com \
--cc=bzolnier@gmail.com \
--cc=kumar.gala@Freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox