From: Nikhil Kumar Singh <nikhilks@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/4] powerpc/pseries: Limit PVR list to 16 entries for CAS negotiation
Date: Mon, 3 Aug 2026 08:52:24 +0530 [thread overview]
Message-ID: <181d7792-08f8-4cf2-9490-249de89a2428@linux.ibm.com> (raw)
In-Reply-To: <20260729145405.3230272-2-mahesh@linux.ibm.com>
On 29/07/26 20:24, Mahesh Salgaonkar wrote:
> + if ((ARRAY_SIZE(ibm_architecture_vec_template.pvrs) > 16) &&
> + (PVR_VER(mfspr(SPRN_PVR)) <= PVR_POWER11))
> + start_index = ARRAY_SIZE(ibm_architecture_vec_template.pvrs) - 16;
Hi Mahesh,
The literal 16 appears twice. Please define a named macro,
e.g.: #define CAS_MAX_PVR_ENTRIES 16
Thanks,
~ Nikhil
next prev parent reply other threads:[~2026-08-03 3:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:54 [PATCH 0/4] Base support for Power12 Mahesh Salgaonkar
2026-07-29 14:54 ` [PATCH 1/4] powerpc/pseries: Limit PVR list to 16 entries for CAS negotiation Mahesh Salgaonkar
2026-08-03 3:22 ` Nikhil Kumar Singh [this message]
2026-08-03 4:46 ` Mahesh J Salgaonkar
2026-07-29 14:54 ` [PATCH 2/4] powerpc: Add Power12 raw mode Mahesh Salgaonkar
2026-08-03 3:27 ` Nikhil Kumar Singh
2026-07-29 14:54 ` [PATCH 3/4] powerpc: Add Power12 architected mode Mahesh Salgaonkar
2026-08-03 5:36 ` Nikhil Kumar Singh
2026-08-03 6:14 ` Mahesh J Salgaonkar
2026-08-03 6:40 ` Nikhil Kumar Singh
2026-07-29 14:54 ` [PATCH 4/4] powerpc/perf: Add power12 Base Performance Monitoring support Mahesh Salgaonkar
2026-08-03 3:10 ` Nikhil Kumar Singh
2026-08-03 4:47 ` Mahesh J Salgaonkar
2026-07-30 6:35 ` [PATCH 0/4] Base support for Power12 Praveen K Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181d7792-08f8-4cf2-9490-249de89a2428@linux.ibm.com \
--to=nikhilks@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).